From: Antti Palosaari <crope@iki.fi>
To: Oliver Schinagl <oliver+list@schinagl.nl>
Cc: linux-media <linux-media@vger.kernel.org>
Subject: Re: AF9035 experimental header changes
Date: Sun, 13 May 2012 18:51:36 +0300 [thread overview]
Message-ID: <4FAFD888.8080801@iki.fi> (raw)
In-Reply-To: <4FAFD21D.9000801@schinagl.nl>
On 13.05.2012 18:24, Oliver Schinagl wrote:
> Hi antti,
>
> I've just updated my local branch of your experimental branch and got
> some conflicts because you moved the header inclusions from the C file
> to the header file. Why is that? I thought it was really bad practice to
> have includes in header files.
>
> http://git.linuxtv.org/anttip/media_tree.git/commitdiff/7d28d8226cffd1ad6e555b36f6f9855d8bba8645
Because "struct state" was inside af9013.h and I added "struct
af9033_config" to state. Due to that af9033_config visibility I was
forced to move af9013.h include to the af9015.h and moved all the others
too.
What is problem you has met?
DVB USB driver header file is something like private place for data
other than code as it is not included by any other driver.
regards
Antti
--
http://palosaari.fi/
next prev parent reply other threads:[~2012-05-13 15:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-13 15:24 AF9035 experimental header changes Oliver Schinagl
2012-05-13 15:51 ` Antti Palosaari [this message]
2012-05-13 17:26 ` Oliver Schinagl
2012-05-13 17:39 ` Antti Palosaari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FAFD888.8080801@iki.fi \
--to=crope@iki.fi \
--cc=linux-media@vger.kernel.org \
--cc=oliver+list@schinagl.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.