All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: Maik Broemme <mbroemme@plusserver.de>,
	kernel-janitors@vger.kernel.org, linux-fbdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/video/intelfb/intelfbdrv.c: add missing agp_backend_release
Date: Sun, 13 May 2012 20:50:50 +0000	[thread overview]
Message-ID: <4FB01EAA.8040504@gmx.de> (raw)
In-Reply-To: <1334854553-30067-1-git-send-email-Julia.Lawall@lip6.fr>

On 04/19/2012 04:55 PM, Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
> 
> Release bridge, as done on all other paths out of the function.
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

Looks good to me, applied.


Thanks,

Florian Tobias Schandinat

> 
> ---
>  drivers/video/intelfb/intelfbdrv.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/video/intelfb/intelfbdrv.c b/drivers/video/intelfb/intelfbdrv.c
> index 02fd226..bdcbfba 100644
> --- a/drivers/video/intelfb/intelfbdrv.c
> +++ b/drivers/video/intelfb/intelfbdrv.c
> @@ -680,6 +680,7 @@ static int __devinit intelfb_pci_register(struct pci_dev *pdev,
>  		 + dinfo->fb.size);
>  	if (!dinfo->aperture.virtual) {
>  		ERR_MSG("Cannot remap FB region.\n");
> +		agp_backend_release(bridge);
>  		cleanup(dinfo);
>  		return -ENODEV;
>  	}
> @@ -689,6 +690,7 @@ static int __devinit intelfb_pci_register(struct pci_dev *pdev,
>  					      INTEL_REG_SIZE);
>  	if (!dinfo->mmio_base) {
>  		ERR_MSG("Cannot remap MMIO region.\n");
> +		agp_backend_release(bridge);
>  		cleanup(dinfo);
>  		return -ENODEV;
>  	}
> 
> 


      reply	other threads:[~2012-05-13 20:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-19 16:55 [PATCH] drivers/video/intelfb/intelfbdrv.c: add missing agp_backend_release Julia Lawall
2012-04-19 16:55 ` Julia Lawall
2012-05-13 20:50 ` Florian Tobias Schandinat [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FB01EAA.8040504@gmx.de \
    --to=florianschandinat@gmx.de \
    --cc=Julia.Lawall@lip6.fr \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mbroemme@plusserver.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.