From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Evgeniy Dushistov <dushistov@mail.ru>
Subject: Re: [PATCH] update i_blocks on UFS
Date: Mon, 14 May 2012 00:16:27 +0200 [thread overview]
Message-ID: <4FB032BB.6060209@gmail.com> (raw)
In-Reply-To: <20120513215925.GA1998@maclin>
[-- Attachment #1: Type: text/plain, Size: 1158 bytes --]
On 13.05.2012 23:59, Evgeniy Dushistov wrote:
> On Sun, May 13, 2012 at 03:52:46PM +0200, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
>> UFS code dosn't update i_blocks which leads to the problems ranging from wrong
>> stat/du to long symlinks (as opposed to inline ones) being damaged. This is
>> a fix.
>>
>
> Yes, when quota support was removed, code that update statistic
> about usage of blocks also was removed. But why so big change to fix this?
> I found this problem some time ago and fixed it with code bellow,
> but may be I missed something?
>
Hm, I don't know why this code wasn't in my copy. Was it already
propagated to Linus' tree? When will it be? Which tree I should merge
from to get your latest fixes?
My code avoided counting metadata blocks (the ones holding the pointers
to actual blocks in indirect, double-indirect and triple-indirect
chains). I thought that i_blocks doesn't take into account the
metablocks but quick experiment with NetBSD image proved me wrong. So I
retract this patch altogether.
My UFS file size limit patch remains though.
--
Regards
Vladimir 'φ-coder/phcoder' Serbinenko
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 294 bytes --]
next prev parent reply other threads:[~2012-05-13 22:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-13 13:52 [PATCH] update i_blocks on UFS Vladimir 'φ-coder/phcoder' Serbinenko
2012-05-13 21:59 ` Evgeniy Dushistov
2012-05-13 21:59 ` Evgeniy Dushistov
2012-05-13 22:16 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
2012-05-14 11:57 ` Evgeniy Dushistov
2012-05-14 11:57 ` Evgeniy Dushistov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FB032BB.6060209@gmail.com \
--to=phcoder@gmail.com \
--cc=dushistov@mail.ru \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.