From mboxrd@z Thu Jan 1 00:00:00 1970 From: KAMEZAWA Hiroyuki Subject: Re: [PATCH 2/6] add res_counter_uncharge_until() Date: Mon, 14 May 2012 10:10:39 +0900 Message-ID: <4FB05B8F.8020408@jp.fujitsu.com> References: <4FACDED0.3020400@jp.fujitsu.com> <4FACE01A.4040405@jp.fujitsu.com> <20120511141945.c487e94c.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20120511141945.c487e94c.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" To: Andrew Morton Cc: "linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org" , "cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Michal Hocko , Johannes Weiner , Frederic Weisbecker , Han Ying , Glauber Costa , Tejun Heo , "Aneesh Kumar K.V" , Hiroyuki Kamezawa , Linux Kernel (2012/05/12 6:19), Andrew Morton wrote: > On Fri, 11 May 2012 18:47:06 +0900 > KAMEZAWA Hiroyuki wrote: > >> From: Frederic Weisbecker >> >> At killing res_counter which is a child of other counter, >> we need to do >> res_counter_uncharge(child, xxx) >> res_counter_charge(parent, xxx) >> >> This is not atomic and wasting cpu. This patch adds >> res_counter_uncharge_until(). This function's uncharge propagates >> to ancestors until specified res_counter. >> >> res_counter_uncharge_until(child, parent, xxx) >> >> Now, ops is atomic and efficient. >> >> Changelog since v2 >> - removed unnecessary lines. >> - Fixed 'From' , this patch comes from his series. Please signed-off-by if good. >> >> Signed-off-by: KAMEZAWA Hiroyuki > > Frederic's Signed-off-by: is unavaliable? > I didn't add his Signed-off because I modified his orignal patch a little... I dropped res_counter_charge_until() because it's not used in this series, I have no justification for adding it. The idea of res_counter_uncharge_until() is from his patch. Thanks, -Kame From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx198.postini.com [74.125.245.198]) by kanga.kvack.org (Postfix) with SMTP id 4E0BB6B00E7 for ; Sun, 13 May 2012 21:12:38 -0400 (EDT) Received: from m3.gw.fujitsu.co.jp (unknown [10.0.50.73]) by fgwmail5.fujitsu.co.jp (Postfix) with ESMTP id D62EC3EE0C3 for ; Mon, 14 May 2012 10:12:36 +0900 (JST) Received: from smail (m3 [127.0.0.1]) by outgoing.m3.gw.fujitsu.co.jp (Postfix) with ESMTP id BCF5645DEB3 for ; Mon, 14 May 2012 10:12:36 +0900 (JST) Received: from s3.gw.fujitsu.co.jp (s3.gw.fujitsu.co.jp [10.0.50.93]) by m3.gw.fujitsu.co.jp (Postfix) with ESMTP id 9F46145DEB7 for ; Mon, 14 May 2012 10:12:36 +0900 (JST) Received: from s3.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s3.gw.fujitsu.co.jp (Postfix) with ESMTP id 8CFE01DB8043 for ; Mon, 14 May 2012 10:12:36 +0900 (JST) Received: from m1000.s.css.fujitsu.com (m1000.s.css.fujitsu.com [10.240.81.136]) by s3.gw.fujitsu.co.jp (Postfix) with ESMTP id 1360F1DB8044 for ; Mon, 14 May 2012 10:12:36 +0900 (JST) Message-ID: <4FB05B8F.8020408@jp.fujitsu.com> Date: Mon, 14 May 2012 10:10:39 +0900 From: KAMEZAWA Hiroyuki MIME-Version: 1.0 Subject: Re: [PATCH 2/6] add res_counter_uncharge_until() References: <4FACDED0.3020400@jp.fujitsu.com> <4FACE01A.4040405@jp.fujitsu.com> <20120511141945.c487e94c.akpm@linux-foundation.org> In-Reply-To: <20120511141945.c487e94c.akpm@linux-foundation.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Andrew Morton Cc: "linux-mm@kvack.org" , "cgroups@vger.kernel.org" , Michal Hocko , Johannes Weiner , Frederic Weisbecker , Han Ying , Glauber Costa , Tejun Heo , "Aneesh Kumar K.V" , Hiroyuki Kamezawa , Linux Kernel (2012/05/12 6:19), Andrew Morton wrote: > On Fri, 11 May 2012 18:47:06 +0900 > KAMEZAWA Hiroyuki wrote: > >> From: Frederic Weisbecker >> >> At killing res_counter which is a child of other counter, >> we need to do >> res_counter_uncharge(child, xxx) >> res_counter_charge(parent, xxx) >> >> This is not atomic and wasting cpu. This patch adds >> res_counter_uncharge_until(). This function's uncharge propagates >> to ancestors until specified res_counter. >> >> res_counter_uncharge_until(child, parent, xxx) >> >> Now, ops is atomic and efficient. >> >> Changelog since v2 >> - removed unnecessary lines. >> - Fixed 'From' , this patch comes from his series. Please signed-off-by if good. >> >> Signed-off-by: KAMEZAWA Hiroyuki > > Frederic's Signed-off-by: is unavaliable? > I didn't add his Signed-off because I modified his orignal patch a little... I dropped res_counter_charge_until() because it's not used in this series, I have no justification for adding it. The idea of res_counter_uncharge_until() is from his patch. Thanks, -Kame -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753957Ab2ENBMj (ORCPT ); Sun, 13 May 2012 21:12:39 -0400 Received: from fgwmail5.fujitsu.co.jp ([192.51.44.35]:48798 "EHLO fgwmail5.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753227Ab2ENBMh (ORCPT ); Sun, 13 May 2012 21:12:37 -0400 X-SecurityPolicyCheck: OK by SHieldMailChecker v1.7.4 Message-ID: <4FB05B8F.8020408@jp.fujitsu.com> Date: Mon, 14 May 2012 10:10:39 +0900 From: KAMEZAWA Hiroyuki User-Agent: Mozilla/5.0 (Windows NT 6.0; rv:12.0) Gecko/20120428 Thunderbird/12.0.1 MIME-Version: 1.0 To: Andrew Morton CC: "linux-mm@kvack.org" , "cgroups@vger.kernel.org" , Michal Hocko , Johannes Weiner , Frederic Weisbecker , Han Ying , Glauber Costa , Tejun Heo , "Aneesh Kumar K.V" , Hiroyuki Kamezawa , Linux Kernel Subject: Re: [PATCH 2/6] add res_counter_uncharge_until() References: <4FACDED0.3020400@jp.fujitsu.com> <4FACE01A.4040405@jp.fujitsu.com> <20120511141945.c487e94c.akpm@linux-foundation.org> In-Reply-To: <20120511141945.c487e94c.akpm@linux-foundation.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org (2012/05/12 6:19), Andrew Morton wrote: > On Fri, 11 May 2012 18:47:06 +0900 > KAMEZAWA Hiroyuki wrote: > >> From: Frederic Weisbecker >> >> At killing res_counter which is a child of other counter, >> we need to do >> res_counter_uncharge(child, xxx) >> res_counter_charge(parent, xxx) >> >> This is not atomic and wasting cpu. This patch adds >> res_counter_uncharge_until(). This function's uncharge propagates >> to ancestors until specified res_counter. >> >> res_counter_uncharge_until(child, parent, xxx) >> >> Now, ops is atomic and efficient. >> >> Changelog since v2 >> - removed unnecessary lines. >> - Fixed 'From' , this patch comes from his series. Please signed-off-by if good. >> >> Signed-off-by: KAMEZAWA Hiroyuki > > Frederic's Signed-off-by: is unavaliable? > I didn't add his Signed-off because I modified his orignal patch a little... I dropped res_counter_charge_until() because it's not used in this series, I have no justification for adding it. The idea of res_counter_uncharge_until() is from his patch. Thanks, -Kame