From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from tx2ehsobe004.messaging.microsoft.com ([65.55.88.14]
 helo=tx2outboundpool.messaging.microsoft.com)
 by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux))
 id 1STlGV-0002je-V6
 for linux-mtd@lists.infradead.org; Mon, 14 May 2012 02:44:06 +0000
Message-ID: <4FB07272.4020403@freescale.com>
Date: Mon, 14 May 2012 10:48:18 +0800
From: Huang Shijie <b32955@freescale.com>
MIME-Version: 1.0
To: Brian Norris <computersforpeace@gmail.com>
Subject: Re: [PATCH 3/3] mtd: nand: gpmi: [FIXME] need to use {read,
 write}_oob_raw
References: <1336768235-12658-1-git-send-email-computersforpeace@gmail.com>
 <1336768235-12658-3-git-send-email-computersforpeace@gmail.com>
In-Reply-To: <1336768235-12658-3-git-send-email-computersforpeace@gmail.com>
Content-Type: text/plain; charset="GB2312"
Content-Transfer-Encoding: 7bit
Cc: linux-mtd@lists.infradead.org, Artem Bityutskiy <dedekind1@gmail.com>
List-Id: Linux MTD discussion mailing list <linux-mtd.lists.infradead.org>
List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-mtd>,
 <mailto:linux-mtd-request@lists.infradead.org?subject=unsubscribe>
List-Archive: <http://lists.infradead.org/pipermail/linux-mtd/>
List-Post: <mailto:linux-mtd@lists.infradead.org>
List-Help: <mailto:linux-mtd-request@lists.infradead.org?subject=help>
List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-mtd>,
 <mailto:linux-mtd-request@lists.infradead.org?subject=subscribe>

Hi Brian :
> This patch is simply an added warning in the comments. Ideally, this patch
> need not be merged, but rather, a developer will write a proper solution
> that can use the ecc.read_oob_raw and ecc.write_oob_raw interfaces.
>
> Signed-off-by: Brian Norris <computersforpeace@gmail.com>
> Cc: Huang Shijie <b32955@freescale.com>
> ---
>  drivers/mtd/nand/gpmi-nand/gpmi-nand.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> index 8250f63..033bd7a 100644
> --- a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> +++ b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> @@ -1054,6 +1054,9 @@ exit_auxiliary:
>   * ECC-based or raw view of the page is implicit in which function it calls
>   * (there is a similar pair of ECC-based/raw functions for writing).
>   *
> + * FIXME: The following paragraph is incorrect, now that there exist
> + * ecc.read_oob_raw and ecc.write_oob_raw functions.
I think you can just remove the following paragraph(it's out of date now).

Best Regards
Huang Shijie
> + *
>   * Since MTD assumes the OOB is not covered by ECC, there is no pair of
>   * ECC-based/raw functions for reading or or writing the OOB. The fact that the
>   * caller wants an ECC-based or raw view of the page is not propagated down to