From: Xiaofeng Yan <xiaofeng.yan@windriver.com>
To: <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 1/1] archiver.bbclass: Add default set
Date: Mon, 14 May 2012 15:54:45 +0800 [thread overview]
Message-ID: <4FB0BA45.5060008@windriver.com> (raw)
In-Reply-To: <CABcZANkNAkmLA72kaa=Dv0YExnji__tOJ16moRhDGRmfi0NaVw@mail.gmail.com>
On 2012年05月11日 22:14, Chris Larson wrote:
> On Fri, May 11, 2012 at 3:13 AM,<xiaofeng.yan@windriver.com> wrote:
>> diff --git a/meta/classes/archiver.bbclass b/meta/classes/archiver.bbclass
>> index 59b58f4..a720db2 100644
>> --- a/meta/classes/archiver.bbclass
>> +++ b/meta/classes/archiver.bbclass
>> @@ -6,6 +6,10 @@ ARCHIVE_EXCLUDE_FROM ?= ".pc autom4te.cache"
>> ARCHIVE_TYPE ?= "TAR SRPM"
>> DISTRO ?= "poky"
>> PATCHES_ARCHIVE_WITH_SERIES = 'TRUE'
>> +SOURCE_ARCHIVE_LOG_WITH_SCRIPTS ?= 'logs_with_scripts'
>> +SOURCE_ARCHIVE_PACKAGE_TYPE ?= 'tar'
>> +export SOURCE_ARCHIVE_LOG_WITH_SCRIPTS
>> +export SOURCE_ARCHIVE_PACKAGE_TYPE
> I don't think you understand what 'export' does or why it exists.
> Please fix that, and remove these lines. Thanks.
Hi Chris Larson,
Thanks for your review. I am testing this according to your
suggestion and put it to OE-core after test.
Thanks
Yan
prev parent reply other threads:[~2012-05-14 8:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-11 10:13 [PATCH 0/1] archiver.bbclass: Add two default set for avoiding error when missing assignment xiaofeng.yan
2012-05-11 10:13 ` [PATCH 1/1] archiver.bbclass: Add default set xiaofeng.yan
2012-05-11 14:14 ` Chris Larson
2012-05-14 7:54 ` Xiaofeng Yan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FB0BA45.5060008@windriver.com \
--to=xiaofeng.yan@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.