All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
	qemu-devel@nongnu.org, xen-devel <xen-devel@lists.xen.org>
Subject: Re: [Qemu-devel] [PATCH, v2] qemu/xendisk: properly update stats in ioreq_release()
Date: Mon, 14 May 2012 13:53:25 +0200	[thread overview]
Message-ID: <4FB0F235.1030900@redhat.com> (raw)
In-Reply-To: <4FB0FAC8020000780008369A@nat28.tlf.novell.com>

Am 14.05.2012 12:30, schrieb Jan Beulich:
> While for the "normal" case (called from blk_send_response_all())
> decrementing requests_finished is correct, doing so in the parse error
> case is wrong; requests_inflight needs to be decremented instead.
> 
> Change in v2: Adjust coding style.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

I think it would be nicer if a struct ioreq had an explicit state so
that you don't have to pass the right state when releasing it. But
anyway, the patch looks correct to me:

Reviewed-by: Kevin Wolf <kwolf@redhat.com>

  parent reply	other threads:[~2012-05-14 11:53 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-14 10:30 [Qemu-devel] [PATCH, v2] qemu/xendisk: properly update stats in ioreq_release() Jan Beulich
2012-05-14 11:53 ` Kevin Wolf
2012-05-14 11:53 ` Kevin Wolf [this message]
2012-05-14 14:57 ` Stefano Stabellini
2012-05-15  8:56   ` Kevin Wolf
2012-05-15 10:16     ` Stefano Stabellini
2012-05-15 10:32       ` Kevin Wolf
2012-05-15 10:32       ` Kevin Wolf
2012-05-15 10:16     ` Stefano Stabellini
2012-05-15  8:56   ` Kevin Wolf
2012-05-14 14:57 ` Stefano Stabellini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FB0F235.1030900@redhat.com \
    --to=kwolf@redhat.com \
    --cc=JBeulich@suse.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.