From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:50955) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1STtuu-0004dC-13 for qemu-devel@nongnu.org; Mon, 14 May 2012 07:58:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1STtur-0004Vp-Vu for qemu-devel@nongnu.org; Mon, 14 May 2012 07:58:19 -0400 Received: from cantor2.suse.de ([195.135.220.15]:53403 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1STtur-0004Vh-P4 for qemu-devel@nongnu.org; Mon, 14 May 2012 07:58:17 -0400 Message-ID: <4FB0F355.5070601@suse.de> Date: Mon, 14 May 2012 13:58:13 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1336749740-18474-1-git-send-email-armbru@redhat.com> <1336749740-18474-3-git-send-email-armbru@redhat.com> <4FB0C6A7.2040308@redhat.com> In-Reply-To: <4FB0C6A7.2040308@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [RFC PATCH 2/2] Split fdd devices off the floppy controller List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , Markus Armbruster Cc: Paolo Bonzini , aliguori@us.ibm.com, hpoussin@reactos.org, qemu-devel@nongnu.org Am 14.05.2012 10:47, schrieb Kevin Wolf: > Am 11.05.2012 17:22, schrieb Markus Armbruster: >> For historical reasons, and unlike other block devices, our floppy >> devices isa-fdc, sysbus-fdc and SUNW,fdtwo integrate the controller >> and the drive(s) in a single qdev. This makes them weird: we need >> -global to set up floppy drives, unlike every other optional device. >=20 > I like the idea of splitting the drives from the controller. In fact, I > think we could even try to split them into a separate hw/fdd.c Seconded, however that might make the patch harder to read due to the code movements. >> Unfortunately, eliding the qbus means I can't make the floppy disk a >> qdev (sub-class of TYPE_DEVICE), because qdevs can only connect to a >> qbus. Anthony tells me that restriction is gone in his latest QOM >> series. >> >> Since it's not a qdev, -device fdd does not work. Pity, because it >> defeats the stated purpose of making floppy disk drives work like >> other existing optional devices. >=20 > As long as this is true, committing a patch like this doesn't help a > lot, so I hope Anthony's patches will go in before this is ready. Having gone through nearly all QOM patches on the list for qom-next, this is not something I remember seeing yet. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg