From: Bruce Ashfield <bruce.ashfield@windriver.com>
To: <tom.zanussi@intel.com>
Cc: yocto@yoctoproject.org, dvhart@linux.intel.com
Subject: Re: [PATCH 00/22][KERNEL][RFC] policy cleanup patches, v2
Date: Mon, 14 May 2012 11:22:30 -0400 [thread overview]
Message-ID: <4FB12336.1000602@windriver.com> (raw)
In-Reply-To: <cover.1336851382.git.tom.zanussi@intel.com>
On 12-05-12 03:42 PM, tom.zanussi@intel.com wrote:
> From: Tom Zanussi<tom.zanussi@intel.com>
>
> This set of patches factors out the policy vs hardware-related config
> of the common-pc and common-pc-64 along with some meta-intel BSPs.
>
> There are also a couple usb cleanups as well.
>
> This is still an RFC patchset because it's completely untested at this
> point so shouldn't be pulled in yet.
>
> v2: updated to reflect Darren's comments. This new patchset also
> adds the usb-mass-storage feature to common-pc and common-pc-64,
> and at the same time factors out the common SCSI pieces into a new
> set of scsi features. It also removes options and feature use made
> redundant by the above changes.
I gave this a scan and it looks good to me. I've wanted to break out
scsi changes in the past, so the split looks like a good starting
point to me. Not knowing every option in the subsystem off by heart,
I like to explicitly include something that says "I need a scsi disk
or cdrom" .. so I like the clarify.
The USB cleanups look good with me.
Once we get this tested and in tree, I'll experiment with changing
some of the hardware/non-hardware designations to required/optional
naming and see what the audit subsystem has to say about it. But that's
orthogonal to this factoring and cleanup.
Cheers,
Bruce
>
> Tom
>
> The following changes since commit 1dfd60fa1250259eed38ae5b2840eb37e3758a1b:
> Tom Zanussi (1):
> meta/fishriver: move smp options from recipe-space
>
> are available in the git repository at:
>
> git://git.yoctoproject.org/linux-yocto-2.6.37-contrib.git tzanussi/policy-cleanup
> http://git.yoctoproject.org/cgit/cgit.cgi/linux-yocto-2.6.37-contrib/log/?h=tzanussi/policy-cleanup
>
> Tom Zanussi (22):
> meta: add ROOT_HUB_TT config option to the usb/ehci-hcd feature
> meta/common-pc: use usb features
> meta/common-pc-64: use usb features
> meta/common-pc: factor out policy-related options
> meta/common-pc-64: factor out policy-related options
> meta/crownbay: factor out policy-related options
> meta/emenlow: factor out policy-related options
> meta/fishriver: factor out policy-related options
> meta/jasperforest: factor out policy-related options
> meta/sugarbay: factor out policy-related options
> meta: add scsi feature
> meta: add scsi disk feature
> meta: factor out SCSI options from the usb-mass-storage feature
> meta/common-pc: use usb-mass-storage feature
> meta: add scsi cdrom feature
> meta/common-pc-64: use usb-mass-storage feature
> meta/common-pc-64: factor out SCSI CDROM option
> meta/jasperforest: remove redundant features and options
> meta/sugarbay: remove redundant features and options
> meta/crownbay: remove redundant features and options
> meta/emenlow: remove redundant features and options
> meta/fishriver: remove redundant features and options
>
> .../bsp/common-pc-64/common-pc-64-preempt-rt.scc | 7 +++++++
> .../bsp/common-pc-64/common-pc-64-standard.scc | 7 +++++++
> .../kernel-cache/bsp/common-pc-64/common-pc-64.cfg | 8 --------
> .../kernel-cache/bsp/common-pc-64/common-pc-64.scc | 10 ++++------
> .../bsp/common-pc/common-pc-preempt-rt.scc | 8 ++++++++
> .../bsp/common-pc/common-pc-standard.scc | 7 +++++++
> .../kernel-cache/bsp/common-pc/common-pc-tiny.scc | 5 +----
> meta/cfg/kernel-cache/bsp/common-pc/common-pc.cfg | 8 --------
> meta/cfg/kernel-cache/bsp/common-pc/common-pc.scc | 7 +++----
> .../bsp/crownbay/crownbay-preempt-rt.scc | 8 ++++++++
> .../bsp/crownbay/crownbay-standard.scc | 7 +++++++
> meta/cfg/kernel-cache/bsp/crownbay/crownbay.cfg | 1 -
> meta/cfg/kernel-cache/bsp/crownbay/crownbay.scc | 8 --------
> .../bsp/emenlow/emenlow-preempt-rt.scc | 8 ++++++++
> .../kernel-cache/bsp/emenlow/emenlow-standard.scc | 8 ++++++++
> meta/cfg/kernel-cache/bsp/emenlow/emenlow.cfg | 1 -
> meta/cfg/kernel-cache/bsp/emenlow/emenlow.scc | 8 --------
> .../bsp/fishriver/fishriver-preempt-rt.scc | 8 ++++++++
> .../bsp/fishriver/fishriver-standard.scc | 8 ++++++++
> meta/cfg/kernel-cache/bsp/fishriver/fishriver.cfg | 1 -
> meta/cfg/kernel-cache/bsp/fishriver/fishriver.scc | 8 --------
> .../bsp/jasperforest/jasperforest-preempt-rt.scc | 4 ++++
> .../bsp/jasperforest/jasperforest-standard.scc | 3 +++
> .../kernel-cache/bsp/jasperforest/jasperforest.cfg | 1 -
> .../kernel-cache/bsp/jasperforest/jasperforest.scc | 8 --------
> .../bsp/sugarbay/sugarbay-preempt-rt.scc | 4 ++++
> .../bsp/sugarbay/sugarbay-standard.scc | 3 +++
> meta/cfg/kernel-cache/bsp/sugarbay/sugarbay.cfg | 1 -
> meta/cfg/kernel-cache/bsp/sugarbay/sugarbay.scc | 8 --------
> meta/cfg/kernel-cache/cfg/usb-mass-storage.cfg | 2 --
> meta/cfg/kernel-cache/cfg/usb-mass-storage.scc | 2 ++
> meta/cfg/kernel-cache/features/scsi/cdrom.cfg | 1 +
> meta/cfg/kernel-cache/features/scsi/cdrom.scc | 6 ++++++
> meta/cfg/kernel-cache/features/scsi/disk.cfg | 1 +
> meta/cfg/kernel-cache/features/scsi/disk.scc | 6 ++++++
> meta/cfg/kernel-cache/features/scsi/scsi.cfg | 1 +
> meta/cfg/kernel-cache/features/scsi/scsi.scc | 4 ++++
> meta/cfg/kernel-cache/features/usb/ehci-hcd.cfg | 1 +
> 38 files changed, 120 insertions(+), 77 deletions(-)
> create mode 100644 meta/cfg/kernel-cache/features/scsi/cdrom.cfg
> create mode 100644 meta/cfg/kernel-cache/features/scsi/cdrom.scc
> create mode 100644 meta/cfg/kernel-cache/features/scsi/disk.cfg
> create mode 100644 meta/cfg/kernel-cache/features/scsi/disk.scc
> create mode 100644 meta/cfg/kernel-cache/features/scsi/scsi.cfg
> create mode 100644 meta/cfg/kernel-cache/features/scsi/scsi.scc
>
prev parent reply other threads:[~2012-05-14 15:22 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-12 19:42 [PATCH 00/22][KERNEL][RFC] policy cleanup patches, v2 tom.zanussi
2012-05-12 19:41 ` [PATCH 01/22] meta: add ROOT_HUB_TT config option to the usb/ehci-hcd feature tom.zanussi
2012-05-12 19:41 ` [PATCH 02/22] meta/common-pc: use usb features tom.zanussi
2012-05-12 19:41 ` [PATCH 03/22] meta/common-pc-64: " tom.zanussi
2012-05-12 19:41 ` [PATCH 04/22] meta/common-pc: factor out policy-related options tom.zanussi
2012-05-12 19:41 ` [PATCH 05/22] meta/common-pc-64: " tom.zanussi
2012-05-12 19:41 ` [PATCH 06/22] meta/crownbay: " tom.zanussi
2012-05-12 19:41 ` [PATCH 07/22] meta/emenlow: " tom.zanussi
2012-05-12 19:41 ` [PATCH 08/22] meta/fishriver: " tom.zanussi
2012-05-12 19:41 ` [PATCH 09/22] meta/jasperforest: " tom.zanussi
2012-05-14 16:30 ` Darren Hart
2012-05-14 19:57 ` Tom Zanussi
2012-05-14 20:15 ` Darren Hart
2012-05-12 19:41 ` [PATCH 10/22] meta/sugarbay: " tom.zanussi
2012-05-14 16:31 ` Darren Hart
2012-05-12 19:41 ` [PATCH 11/22] meta: add scsi feature tom.zanussi
2012-05-14 16:36 ` Darren Hart
2012-05-14 19:55 ` Tom Zanussi
2012-05-14 20:15 ` Darren Hart
2012-05-12 19:41 ` [PATCH 12/22] meta: add scsi disk feature tom.zanussi
2012-05-12 19:41 ` [PATCH 13/22] meta: factor out SCSI options from the usb-mass-storage feature tom.zanussi
2012-05-12 19:41 ` [PATCH 14/22] meta/common-pc: use " tom.zanussi
2012-05-12 19:42 ` [PATCH 15/22] meta: add scsi cdrom feature tom.zanussi
2012-05-12 19:42 ` [PATCH 16/22] meta/common-pc-64: use usb-mass-storage feature tom.zanussi
2012-05-12 19:42 ` [PATCH 17/22] meta/common-pc-64: factor out SCSI CDROM option tom.zanussi
2012-05-12 19:42 ` [PATCH 18/22] meta/jasperforest: remove redundant features and options tom.zanussi
2012-05-12 19:42 ` [PATCH 19/22] meta/sugarbay: " tom.zanussi
2012-05-12 19:42 ` [PATCH 20/22] meta/crownbay: " tom.zanussi
2012-05-12 19:42 ` [PATCH 21/22] meta/emenlow: " tom.zanussi
2012-05-12 19:42 ` [PATCH 22/22] meta/fishriver: " tom.zanussi
2012-05-14 15:22 ` Bruce Ashfield [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FB12336.1000602@windriver.com \
--to=bruce.ashfield@windriver.com \
--cc=dvhart@linux.intel.com \
--cc=tom.zanussi@intel.com \
--cc=yocto@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.