From: Eric Blake <eblake@redhat.com>
To: Michael Roth <mdroth@linux.vnet.ibm.com>
Cc: qemu-devel@nongnu.org, lcapitulino@redhat.com
Subject: Re: [Qemu-devel] [PATCH 1/2] qemu-ga: guest-suspend: make the API synchronous
Date: Mon, 14 May 2012 09:30:37 -0600 [thread overview]
Message-ID: <4FB1251D.9010803@redhat.com> (raw)
In-Reply-To: <1337007392-30304-2-git-send-email-mdroth@linux.vnet.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 931 bytes --]
On 05/14/2012 08:56 AM, Michael Roth wrote:
> From: Luiz Capitulino <lcapitulino@redhat.com>
>
> Currently, qemu-ga has a SIGCHLD handler that automatically reaps terminated
> children processes. The idea is to avoid having qemu-ga commands blocked
> waiting for children to terminate.
>
> This commit does just that. There's a side effect though, guest-shutdown
> will generate zombies if shutting down fails. This will be fixed by the
> next commit.
>
> Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
> Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
> ---
> qemu-ga.c | 17 +------
> qga/commands-posix.c | 128 +++++++++++++++++++++-----------------------------
> 2 files changed, 55 insertions(+), 90 deletions(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake@redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 620 bytes --]
next prev parent reply other threads:[~2012-05-14 15:30 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-11 19:19 [Qemu-devel] [PATCH 0/2]: qemu-ga: make shutdown & suspend synchronous Luiz Capitulino
2012-05-11 19:19 ` [Qemu-devel] [PATCH 1/2] qemu-ga: guest-suspend: make the API synchronous Luiz Capitulino
2012-05-11 22:10 ` Eric Blake
2012-05-11 19:19 ` [Qemu-devel] [PATCH 2/2] qemu-ga: guest-shutdown: become synchronous Luiz Capitulino
2012-05-11 22:11 ` Eric Blake
2012-05-14 14:56 ` [Qemu-devel] [PATCH 0/2]: qemu-ga: make shutdown & suspend synchronous Michael Roth
2012-05-14 14:56 ` [Qemu-devel] [PATCH 1/2] qemu-ga: guest-suspend: make the API synchronous Michael Roth
2012-05-14 15:30 ` Eric Blake [this message]
2012-05-14 14:56 ` [Qemu-devel] [PATCH 2/2] qemu-ga: guest-shutdown: become synchronous Michael Roth
2012-05-14 15:31 ` Eric Blake
2012-05-14 16:39 ` [Qemu-devel] [PATCH 0/2]: qemu-ga: make shutdown & suspend synchronous Luiz Capitulino
2012-05-14 17:19 ` Michael Roth
2012-05-14 17:26 ` Luiz Capitulino
2012-05-14 17:06 ` Michal Privoznik
2012-05-14 17:14 ` Luiz Capitulino
2012-05-14 17:17 ` Eric Blake
2012-05-14 18:12 ` Michael Roth
2012-05-14 18:18 ` Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FB1251D.9010803@redhat.com \
--to=eblake@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.