Re: [PATCH] dtc: check for duplicate labels when they are defined

[Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>]

On 04/02/2012 08:46 PM, David Gibson wrote:
> On Tue, Mar 27, 2012 at 09:39:44PM -0600, Stephen Warren wrote:
>> Currently, the DT is checked for duplicate labels after the entire DT has
>> been parsed. However, once parts of the DT can be deleted, some entities
>> with labels may have been deleted by this time, thus making those labels
>> invisible to the duplicate label check, which can then lead to false
>> negatives.
>>
>> Instead, maintain a list of all known labels, from which entries are
>> never deleted, and check against this list for duplicates when adding
>> labels.
>>
>> Signed-off-by: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
>> ---
>> This patch should be applied before my previously posted "dtc: Add
>> ability to delete nodes and properties". I believe it addresses David's
>> concerns with that patch re: the assumption that labels are
>> immutable.
> 
> Hm, I suppose it does.  Or at least it removes the more complex
> objections.  I'd still want to relook at the deletion patch to
> convince myself that the syntax is as good as we can reasonably make
> it.
> 
> This patch is a bit of a hack, and I'm not thrilled at the loss of
> information from the error message, but I can live wth it.
> 
> The other approach I was thinking of, which is hacky in different
> ways, would be to change the deletion patch so that instead of
> actually removing the deleted nodes from the tree, just marks them as
> deleted.  They'd then be omitted from the output pass, but the labels
> attached therein can still be found.

So is this patch good to be applied, or would you rather it was reworked
according the other approach you mentioned?