From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40346) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SU2Ux-0006zD-PI for qemu-devel@nongnu.org; Mon, 14 May 2012 17:08:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SU2Uu-0006x4-Mz for qemu-devel@nongnu.org; Mon, 14 May 2012 17:08:07 -0400 Received: from v220110690675601.yourvserver.net ([78.47.199.172]:46190) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SU2Uu-0006wc-GO for qemu-devel@nongnu.org; Mon, 14 May 2012 17:08:04 -0400 Message-ID: <4FB17431.5020209@weilnetz.de> Date: Mon, 14 May 2012 23:08:01 +0200 From: Stefan Weil MIME-Version: 1.0 References: <4FB1672D.7000906@rdsoftware.de> <4FB16B68.3040307@weilnetz.de> <4FB17210.4030609@codemonkey.ws> In-Reply-To: <4FB17210.4030609@codemonkey.ws> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] Posting a patch? List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Peter Maydell , "qemu-devel@nongnu.org" , Erik Rull Am 14.05.2012 22:58, schrieb Anthony Liguori: > On 05/14/2012 03:53 PM, Peter Maydell wrote: >> On 14 May 2012 21:30, Stefan Weil wrote: >>> if you use git for sending, you don't risk that your mailer destroys >>> the >>> format of your patch. >>> I usually use these commands to send a single patch from the QEMU >>> source >>> directory: >>> >>> # Create the patch file (name depends on the subject line of >>> your patch). >>> git format-patch HEAD^ >>> # Check the patch (fix any issues which were found). >>> scripts/checkpatch.pl 0001-* >>> # Get the maintainer who is responsible (there is not always one). >>> scripts/get_maintainer.pl 0001-* >>> # Send the patch. >>> git send-email --to qemu-devel@nongnu.org --to >>> "n.n" >>> 0001-* >> >> If you do this more than once in the same git tree you'll regret it :-) >> ("git send-email 0001-*" will happily retransmit all the old 0001-foo >> patches along with the new one...) I use git-format-patch's -o option to >> put my sent patches in a separate directory so they don't clutter up the >> working tree. > > You can also do: > > git send-email --to=qemu-devel@nongnu.org HEAD~1 > > Which avoids any clutter. ... and also avoids nasty messages from checkpatch.pl :-) But as this method tends to add clutter to the qemu code or to the mailing list, it should be avoided. > > Regards, > > Anthony Liguori Cheers, Stefan W.