From: Or Gerlitz <ogerlitz@mellanox.com>
To: David Miller <davem@davemloft.net>
Cc: <roland@kernel.org>, <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next 1/8] net/mlx4: Address build warnings on set but not used variables
Date: Tue, 15 May 2012 09:16:58 +0300 [thread overview]
Message-ID: <4FB1F4DA.9050403@mellanox.com> (raw)
In-Reply-To: <20120515.015916.1228365475475285173.davem@davemloft.net>
On 5/15/2012 8:59 AM, David Miller wrote:
> I can't tell if it's right, becuase it got all reformatted by your
> mail client. You simply need to make sure the arguments on the second
> and further lines line up with the column after the openning
> parenthesis on the first line.
Oh I see you point now, indeed, there were two cases in this patch where
I replaced "err = " which spans six chars with "(void) " which spans
seven, so what I needs to be done here is to add a tab in the 2nd, etc
lines or a space? BTW there are such changes only in this patch (1/8).
Or.
next prev parent reply other threads:[~2012-05-15 6:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-14 20:04 [PATCH net-next 0/8] batch of mlx4 driver fixes Or Gerlitz
2012-05-14 20:04 ` [PATCH net-next 1/8] net/mlx4: Address build warnings on set but not used variables Or Gerlitz
2012-05-15 4:07 ` David Miller
2012-05-15 5:52 ` Or Gerlitz
2012-05-15 5:59 ` David Miller
2012-05-15 6:16 ` Or Gerlitz [this message]
2012-05-14 20:04 ` [PATCH net-next 2/8] net/mlx4_core: Fix init_port mask state for slaves Or Gerlitz
2012-05-14 20:04 ` [PATCH net-next 3/8] net/mlx4_core: Change SYNC_TPT to be native (not wrapped) Or Gerlitz
2012-05-14 20:04 ` [PATCH net-next 4/8] net/mlx4_core: Remove unused *_str functions from the resource tracker Or Gerlitz
2012-05-14 20:04 ` [PATCH net-next 5/8] net/mlx4_core: Do not reset module-parameter num_vfs when fail to enable sriov Or Gerlitz
2012-05-14 20:04 ` [PATCH net-next 6/8] net/mlx4_core: Fix potential kernel Oops in res tracker during Dom0 driver unload Or Gerlitz
2012-05-14 20:04 ` [PATCH net-next 7/8] net/mlx4_core: Add XRC domains and counters to resource tracker Or Gerlitz
2012-05-14 20:04 ` [PATCH net-next 8/8] net/mlx4_core: Fixed error flow in rem_slave_eqs Or Gerlitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FB1F4DA.9050403@mellanox.com \
--to=ogerlitz@mellanox.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=roland@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.