From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:42559) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SUDYk-0005sR-Uf for qemu-devel@nongnu.org; Tue, 15 May 2012 04:56:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SUDYf-0006aQ-KQ for qemu-devel@nongnu.org; Tue, 15 May 2012 04:56:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:20413) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SUDYf-0006aC-Ci for qemu-devel@nongnu.org; Tue, 15 May 2012 04:56:41 -0400 Message-ID: <4FB21A3F.6060509@redhat.com> Date: Tue, 15 May 2012 10:56:31 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <4FB0FAC8020000780008369A@nat28.tlf.novell.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH, v2] qemu/xendisk: properly update stats in ioreq_release() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefano Stabellini Cc: "qemu-devel@nongnu.org" , Jan Beulich , xen-devel Am 14.05.2012 16:57, schrieb Stefano Stabellini: > On Mon, 14 May 2012, Jan Beulich wrote: >> While for the "normal" case (called from blk_send_response_all()) >> decrementing requests_finished is correct, doing so in the parse error >> case is wrong; requests_inflight needs to be decremented instead. >> >> Change in v2: Adjust coding style. >> >> Signed-off-by: Jan Beulich > > Acked-by: Stefano Stabellini Aren't you going to send a pull request yourself, Stefano? Kevin