From: Wanlong Gao <gaowanlong@cn.fujitsu.com>
To: Marioh mrs <marios.makris@gmail.com>
Cc: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH 3/3] Changed nconv variable from long to int in /lib/bytes_by_prefix.c
Date: Tue, 15 May 2012 20:02:16 +0800 [thread overview]
Message-ID: <4FB245C8.2040801@cn.fujitsu.com> (raw)
In-Reply-To: <CAMYrgfQUi_LziMsMsAkSnQdYS6FAryf71dHx6CHX_z5xJDPQmg@mail.gmail.com>
On 05/15/2012 07:51 PM, Marioh mrs wrote:
> On 14 May 2012 10:24, Wanlong Gao <gaowanlong@cn.fujitsu.com> wrote:
>>
>>
>> But Marios,
>>
>> In the previous patch, you changed the library function
>> from str_to_bytes to bytes_by_prefix, if you'd prefer
>> the latter name, please also replace the using of str_to_bytes
>> with the new name, if not, it'll not be compiled.
>>
>> Thanks,
>> Wanlong Gao
>>
>
> Hello Wanlong,
>
> The replacement of usages of the str_to_bytes (now bytes_by_prefix)
> is already done and are part of the previous patch as well.
>
> Quoting that part from the previous patch:
>> Furthermore any call to the file or its functions by other functions,
>> manpages etc. have been modified to comply with the new names.
>
> Furthermore i have tested compiling it (clean compile of the repo and then
> applying the patches and recompiling as well as clean compilation with
> my commits) on two computers and it compiled well.
>
> I hope i didn't misunderstand your comment, please tell me where i am
> wrong if that is the case.
>
> Thanks a lot for reviewing.
At least you can take a look at here ./testcases/kernel/fs/doio/iogen.c
Thanks,
Wanlong Gao
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2012-05-15 12:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1336655089-26941-1-git-send-email-marios.makris@gmail.com>
2012-05-14 7:15 ` [LTP] [PATCH 1/3] Indentation and coding style fixes on /lib/str_to_bytes.c as well as /include/str_to_bytes.h Wanlong Gao
2012-05-16 14:23 ` Cyril Hrubis
[not found] ` <1336655089-26941-2-git-send-email-marios.makris@gmail.com>
2012-05-14 7:16 ` [LTP] [PATCH 2/3] Renamed /lib/str_to_bytes.c and /include str_to bytes.h Wanlong Gao
[not found] ` <1336655089-26941-3-git-send-email-marios.makris@gmail.com>
2012-05-14 7:24 ` [LTP] [PATCH 3/3] Changed nconv variable from long to int in /lib/bytes_by_prefix.c Wanlong Gao
2012-05-15 11:51 ` Marioh mrs
2012-05-15 12:02 ` Wanlong Gao [this message]
2012-05-15 12:36 ` Marioh mrs
2012-05-15 12:50 ` Wanlong Gao
2012-05-15 12:58 ` Marioh mrs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FB245C8.2040801@cn.fujitsu.com \
--to=gaowanlong@cn.fujitsu.com \
--cc=ltp-list@lists.sourceforge.net \
--cc=marios.makris@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.