All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lars-Peter Clausen <lars@metafoo.de>
To: Guenter Roeck <guenter.roeck@ericsson.com>
Cc: "R, Durgadoss" <durgadoss.r@intel.com>,
	"Tc, Jenny" <jenny.tc@intel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>,
	Jonathan Cameron <jic23@kernel.org>
Subject: Re: [lm-sensors] [PATCH] hwmon: Generic ADC support for hwmon
Date: Tue, 15 May 2012 14:18:41 +0000	[thread overview]
Message-ID: <4FB265C1.7060306@metafoo.de> (raw)
In-Reply-To: <20120515134257.GA21933@ericsson.com>

On 05/15/2012 03:42 PM, Guenter Roeck wrote:
> On Tue, May 15, 2012 at 08:42:57AM -0400, R, Durgadoss wrote:
>> Hi Guenter,
>>
>> Thanks for a quick reply.
>>
>>> On Tue, May 15, 2012 at 10:26:48AM -0400, Jenny TC wrote:
>>>> Currently drivers are using custom APIs to communicate with ADC driver.
>>>> So it make sense to have generic APIs to commnicate with ADC drivers.
>>>> This patch introduces generic APIs to communicate with ADC drivers.
>>>>
>>>> Signed-off-by: Jenny TC <jenny.tc@intel.com>
>>>
>>> Hi Jenny,
>>>
>>> Do you have a practical use case ?
>>
>> We have some platform specific component drivers, thermal drivers,
>> battery drivers using this General purpose ADC in the platform.
>> That's why we thought of doing something like this.
>>
>>>
>>> Also, shouldn't those generic ADCs rather be supported through the IO
>>> subsystem ?
>>> After all, hwmon is all about hardware monitoring, not to provide generic ADC
>>> access.
>>
>> In this case, can we try this in iio or mfd subsystem ?
>> Kindly advise.
>>
> I meant iio (more specifically staging/iio/adc).
> 
> I suspect it might make more sense to have a hwmon client, in parallel to the other
> users/clients (battery control, thermal etc), if the values reported by the ADC reflect
> information relevant for hardware monitoring.
> 

So there is already an experimental IIO to hwmon bridge in
drivers/staging/iio/, which you can use to expose a IIO ADC driver as an
hwmon device.

Add Jonathan to Cc.

- Lars

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

WARNING: multiple messages have this Message-ID (diff)
From: Lars-Peter Clausen <lars@metafoo.de>
To: Guenter Roeck <guenter.roeck@ericsson.com>
Cc: "R, Durgadoss" <durgadoss.r@intel.com>,
	"Tc, Jenny" <jenny.tc@intel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>,
	Jonathan Cameron <jic23@kernel.org>
Subject: Re: [lm-sensors] [PATCH] hwmon: Generic ADC support for hwmon
Date: Tue, 15 May 2012 16:18:41 +0200	[thread overview]
Message-ID: <4FB265C1.7060306@metafoo.de> (raw)
In-Reply-To: <20120515134257.GA21933@ericsson.com>

On 05/15/2012 03:42 PM, Guenter Roeck wrote:
> On Tue, May 15, 2012 at 08:42:57AM -0400, R, Durgadoss wrote:
>> Hi Guenter,
>>
>> Thanks for a quick reply.
>>
>>> On Tue, May 15, 2012 at 10:26:48AM -0400, Jenny TC wrote:
>>>> Currently drivers are using custom APIs to communicate with ADC driver.
>>>> So it make sense to have generic APIs to commnicate with ADC drivers.
>>>> This patch introduces generic APIs to communicate with ADC drivers.
>>>>
>>>> Signed-off-by: Jenny TC <jenny.tc@intel.com>
>>>
>>> Hi Jenny,
>>>
>>> Do you have a practical use case ?
>>
>> We have some platform specific component drivers, thermal drivers,
>> battery drivers using this General purpose ADC in the platform.
>> That's why we thought of doing something like this.
>>
>>>
>>> Also, shouldn't those generic ADCs rather be supported through the IO
>>> subsystem ?
>>> After all, hwmon is all about hardware monitoring, not to provide generic ADC
>>> access.
>>
>> In this case, can we try this in iio or mfd subsystem ?
>> Kindly advise.
>>
> I meant iio (more specifically staging/iio/adc).
> 
> I suspect it might make more sense to have a hwmon client, in parallel to the other
> users/clients (battery control, thermal etc), if the values reported by the ADC reflect
> information relevant for hardware monitoring.
> 

So there is already an experimental IIO to hwmon bridge in
drivers/staging/iio/, which you can use to expose a IIO ADC driver as an
hwmon device.

Add Jonathan to Cc.

- Lars

  reply	other threads:[~2012-05-15 14:18 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-15  9:00 [lm-sensors] [PATCH] hwmon: Generic ADC support for hwmon Jenny TC
2012-05-15 14:26 ` Jenny TC
2012-05-15 12:13 ` [lm-sensors] " Guenter Roeck
2012-05-15 12:13   ` Guenter Roeck
2012-05-15 12:42   ` [lm-sensors] " R, Durgadoss
2012-05-15 12:42     ` R, Durgadoss
2012-05-15 13:42     ` Guenter Roeck
2012-05-15 13:42       ` Guenter Roeck
2012-05-15 14:18       ` Lars-Peter Clausen [this message]
2012-05-15 14:18         ` Lars-Peter Clausen
2012-05-15 14:31         ` Jonathan Cameron
2012-05-15 14:31           ` Jonathan Cameron
2012-05-16  8:48           ` Tc, Jenny
2012-05-16  8:48             ` Tc, Jenny
2012-05-16  9:57             ` Jonathan Cameron
2012-05-16  9:57               ` Jonathan Cameron
2012-05-15 13:29 ` Aristeu Sergio Rozanski Filho
2012-05-15 13:29   ` Aristeu Sergio Rozanski Filho

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FB265C1.7060306@metafoo.de \
    --to=lars@metafoo.de \
    --cc=durgadoss.r@intel.com \
    --cc=guenter.roeck@ericsson.com \
    --cc=jenny.tc@intel.com \
    --cc=jic23@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.