From: Eric Sandeen <sandeen@sandeen.net>
To: Jan Kara <jack@suse.cz>
Cc: wu.bo@cn.fujitsu.com, xfs@oss.sgi.com
Subject: Re: Test 274 in xfstests
Date: Tue, 15 May 2012 15:18:39 -0500 [thread overview]
Message-ID: <4FB2BA1F.40603@sandeen.net> (raw)
In-Reply-To: <20120515201645.GF26579@quack.suse.cz>
On 5/15/12 3:16 PM, Jan Kara wrote:
> On Tue 15-05-12 13:12:21, Eric Sandeen wrote:
>> On 5/15/12 1:05 PM, Jan Kara wrote:
>>> Hello,
>>>
>>> test 274 fails e.g. for ext3 because it does not support fallocate(). So
>>> I would think the best way to fix the is to add to the test
>>> _require_xfs_io_falloc()
>>> so that the test is run only for filesystems which do support fallocate.
>>> But with that is connected one slightly related question - why does the
>>> test use fallocate(1) binary instead of "xfs_io falloc" command which is
>>> more common in xfstests?
>>>
>>> Honza
>>
>> Argh I'm behind. I had:
>>
>> [PATCH V2] xfstests: several 274 fixups
>>
>> on the list way too long ago.
>>
>> Want to test that out? It has 1 review on the list, I'll merge it
>> soon - if you want to give it a quick test first, go for it :)
> Yup, the patch works for me (since I'm mostly interested in ext3 not
> being tested ;). I also reviewed your patch and it looks OK so feel free to
> add:
> Reviewed-by: Jan Kara <jack@suse.cz>
>
> Just one comment. Messages like:
> echo "Fill fs with 1M IOs; EIO expected" >> $seq.full
> should probably speak of ENOSPC, not EIO, shouldn't they?
Oh, yeah, whoops. thanks.
-Eric
> Honza
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2012-05-15 20:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-15 18:05 Test 274 in xfstests Jan Kara
2012-05-15 18:12 ` Eric Sandeen
2012-05-15 20:16 ` Jan Kara
2012-05-15 20:18 ` Eric Sandeen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FB2BA1F.40603@sandeen.net \
--to=sandeen@sandeen.net \
--cc=jack@suse.cz \
--cc=wu.bo@cn.fujitsu.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.