From: "Andreas Färber" <afaerber@suse.de>
To: Stefan Weil <sw@weilnetz.de>
Cc: Kevin Wolf <kwolf@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Anthony Liguori <aliguori@us.ibm.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1.1] tests: Add rtc-test (fix test regression)
Date: Wed, 16 May 2012 06:07:19 +0200 [thread overview]
Message-ID: <4FB327F7.5020302@suse.de> (raw)
In-Reply-To: <1337098785-32024-1-git-send-email-sw@weilnetz.de>
Am 15.05.2012 18:19, schrieb Stefan Weil:
> Commit 93e9eb6808c886f5f1c903b7ced1eed65de2ba39 added fdc-test,
> but accidentally removed rtc-test because check-qtest-i386-y was
> not enhanced but set twice.
>
> This patch adds rtc-test again (and sorts both tests alphabetically).
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
Reviewed-by: Andreas Färber <afaerber@suse.de>
I wonder though if it might be better to always just use += because
especially an alphabetical order risks us introducing the same fault again.
Andreas
> ---
> tests/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/Makefile b/tests/Makefile
> index f1b317a..ab7f667 100644
> --- a/tests/Makefile
> +++ b/tests/Makefile
> @@ -18,8 +18,8 @@ check-block-$(CONFIG_POSIX) += tests/qemu-iotests-quick.sh
>
> # All QTests for now are POSIX-only, but the dependencies are
> # really in libqtest, not in the testcases themselves.
> -check-qtest-i386-y = tests/rtc-test$(EXESUF)
> check-qtest-i386-y = tests/fdc-test$(EXESUF)
> +check-qtest-i386-y += tests/rtc-test$(EXESUF)
> check-qtest-x86_64-y = $(check-qtest-i386-y)
> check-qtest-sparc-y = tests/m48t59-test$(EXESUF)
> check-qtest-sparc64-y = tests/m48t59-test$(EXESUF)
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2012-05-16 4:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-15 16:19 [Qemu-devel] [PATCH 1.1] tests: Add rtc-test (fix test regression) Stefan Weil
2012-05-16 4:07 ` Andreas Färber [this message]
2012-05-16 11:00 ` Kevin Wolf
2012-05-19 19:03 ` Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FB327F7.5020302@suse.de \
--to=afaerber@suse.de \
--cc=aliguori@us.ibm.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.