From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:52657) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SUZc9-000086-EO for qemu-devel@nongnu.org; Wed, 16 May 2012 04:29:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SUZc3-0003CH-9r for qemu-devel@nongnu.org; Wed, 16 May 2012 04:29:44 -0400 Received: from mel.act-europe.fr ([194.98.77.210]:38318) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SUZc3-0003BJ-3U for qemu-devel@nongnu.org; Wed, 16 May 2012 04:29:39 -0400 Message-ID: <4FB3656C.4000904@adacore.com> Date: Wed, 16 May 2012 10:29:32 +0200 From: Fabien Chouteau MIME-Version: 1.0 References: <1337074749-24189-1-git-send-email-chouteau@adacore.com> <4FB25AA9.3010905@suse.de> <4FB27F60.7090304@adacore.com> <4FB32412.8030407@suse.de> In-Reply-To: <4FB32412.8030407@suse.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] Avoid segfault in cpu_dump_state List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-1?Q?Andreas_F=E4rber?= Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org, agraf@suse.de On 05/16/2012 05:50 AM, Andreas F=E4rber wrote: > Am 15.05.2012 18:08, schrieb Fabien Chouteau: >> On 05/15/2012 03:31 PM, Andreas F=E4rber wrote: >>> Am 15.05.2012 11:39, schrieb Fabien Chouteau: >>>> Do not call cpu_dump_state if logfile is NULL. >>> >>> And where is log_cpu_state() being called from? Its caller is passing >>> NULL already then. >>> >> >> No, logfile is a global variable. log_cpu_state() takes only CPUState >> and flags parameters. >=20 > Ah, I see now that f is a different f here, logfile becomes > log_cpu_state()'s f. Unfortunate naming. >=20 > Your fix looks OK then but I would recommend turning it into a static > inline function to avoid the line breaks. >=20 In this case I can rewrite all the macros in qemu-log.h to static inline. --=20 Fabien Chouteau