From: Lan Tianyu <tianyu.lan@intel.com>
To: Greg KH <gregkh@linuxfoundation.org>, levinsasha928@gmail.com
Cc: mjg@redhat.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: fix breakage on systems without ACPI
Date: Wed, 16 May 2012 22:05:00 +0800 [thread overview]
Message-ID: <4FB3B40C.3030100@intel.com> (raw)
In-Reply-To: <20120516122153.GA31684@kroah.com>
On 2012年5月16日 20:21:53, Greg KH wrote:
> On Wed, May 16, 2012 at 02:11:15PM +0200, Sasha Levin wrote:
>> Commit da0af6e ("usb: Bind devices to ACPI devices when possible") really
>> tries to force-bind devices even when impossible, unlike what it says in
>> the subject.
>>
>> CONFIG_ACPI is not an indication that ACPI tables are actually present, nor
>> is an indication that any USB relevant information is present in them. There
>> is no reason to fail the creation of a USB bus if it can't bind it to
>> ACPI device during initialization.
>>
>> On systems with CONFIG_ACPI set but without ACPI tables it would cause a
>> boot panic.
>
> Nice catch, sorry about that, I'll go queue this up.
>
> greg k-h
Oh. Sorry for this. I just test it on some my machines that have usb
descriptor.
bring trouble for you.
--
Best Regards
Tianyu Lan
linux kernel enabling team
prev parent reply other threads:[~2012-05-16 14:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-16 12:11 [PATCH] usb: fix breakage on systems without ACPI Sasha Levin
2012-05-16 12:21 ` Greg KH
2012-05-16 14:05 ` Lan Tianyu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FB3B40C.3030100@intel.com \
--to=tianyu.lan@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=levinsasha928@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mjg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.