From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: Jan Kara <jack@suse.cz>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 6/8] Support non-BMP characters in UDF
Date: Wed, 16 May 2012 17:14:23 +0200 [thread overview]
Message-ID: <4FB3C44F.6080409@gmail.com> (raw)
In-Reply-To: <20120516143448.GD27661@quack.suse.cz>
[-- Attachment #1: Type: text/plain, Size: 1059 bytes --]
On 16.05.2012 16:34, Jan Kara wrote:
> On Wed 16-05-12 01:10:22, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
>> I also have a counterpart for mkudffs/udf-tools but sourceforge homepage
>> seems to be abandoned does anybody know if there is a new homepage for
>> mkudffs?
> Thanks for the patch!
You're welcome. Thanks for reviewing.
It looks OK but shouldn't we rather use the helper
> functions you introduced in the NLS code? It look wrong to replicate
> decoding of UTF16 here.
>
The helper functions are limited to buffers aligned on 16-bit boundary
which is not the case of this buffer. I see following solutions:
0) Homegrown like in previous patch
1) Add a new "endianness" UTF16_LITTLE_ENDIAN_UNALIGNED
2) Split code for "compressed" vs "uncompressed" and copy the string to
a temporary buffer in "uncompressed" branch.
3) Like 2 but make buffer sliding and contain only 2 elements.
I think 1 or 3 would be the most reasonable. Which solution do you prefer?
--
Regards
Vladimir 'φ-coder/phcoder' Serbinenko
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 294 bytes --]
next prev parent reply other threads:[~2012-05-16 15:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-15 23:10 [PATCH 6/8] Support non-BMP characters in UDF Vladimir 'φ-coder/phcoder' Serbinenko
2012-05-16 14:34 ` Jan Kara
2012-05-16 15:14 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
2012-05-16 20:04 ` Jan Kara
2012-05-16 20:04 ` Jan Kara
2012-05-17 0:37 ` Vladimir 'φ-coder/phcoder' Serbinenko
2012-05-17 0:48 ` Eliminating UDF iocharset!=utf8 code (Re: [PATCH 6/8] Support non-BMP characters in UDF) Vladimir 'φ-coder/phcoder' Serbinenko
2012-05-17 14:40 ` Jan Kara
2012-05-17 14:40 ` Jan Kara
2012-05-17 15:30 ` Vladimir 'φ-coder/phcoder' Serbinenko
2012-05-17 19:45 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FB3C44F.6080409@gmail.com \
--to=phcoder@gmail.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.