From: Paolo Bonzini <pbonzini@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Anthony PERARD <anthony.perard@citrix.com>,
Xen Devel <xen-devel@lists.xen.org>,
QEMU-devel <qemu-devel@nongnu.org>,
Anthony Liguori <anthony@codemonkey.ws>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [Qemu-devel] [PATCH 1/4] Introduce a new hotplug state: Force eject.
Date: Wed, 16 May 2012 17:52:17 +0200 [thread overview]
Message-ID: <4FB3CD31.8050903@redhat.com> (raw)
In-Reply-To: <20120516132017.GB8620@redhat.com>
Il 16/05/2012 15:20, Michael S. Tsirkin ha scritto:
>>> Because it's missing the object_unparent done by qdev_unplug. Does
>>> object_unparent+qdev_free work? (I believe object_unparent should be
>>> done by qdev_free rather than qdev_unplug, but that's something for 1.2).
>>
>> Cool, this seems to work fine. Thanks.
>>
>> I'll test a bit more and resend a patch with only object_unparent+qdev_free.
>
> Separately it was suggested to make qdev_free do object_unparent
> automatically. Anthony is yet to respond.
Yes, but for 1.1 this Xen-only patch would be nice.
Paolo
next prev parent reply other threads:[~2012-05-16 15:52 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-15 15:26 [Qemu-devel] [PATCH 1.1 0/4] Xen: Fix PV-on-HVM Anthony PERARD
2012-05-15 15:26 ` [Qemu-devel] [PATCH 1/4] Introduce a new hotplug state: Force eject Anthony PERARD
2012-05-15 15:26 ` Anthony PERARD
2012-05-15 18:19 ` [Qemu-devel] " Stefano Stabellini
2012-05-15 18:25 ` Anthony PERARD
2012-05-15 18:25 ` Anthony PERARD
2012-05-15 18:19 ` Stefano Stabellini
2012-05-15 20:52 ` Michael S. Tsirkin
2012-05-15 20:52 ` [Qemu-devel] " Michael S. Tsirkin
2012-05-16 10:32 ` Stefano Stabellini
2012-05-16 10:32 ` [Qemu-devel] " Stefano Stabellini
2012-05-16 11:15 ` Anthony PERARD
2012-05-16 11:23 ` Paolo Bonzini
2012-05-16 11:37 ` Anthony PERARD
2012-05-16 13:20 ` Michael S. Tsirkin
2012-05-16 15:52 ` Paolo Bonzini
2012-05-16 15:52 ` Paolo Bonzini [this message]
2012-05-16 16:25 ` Michael S. Tsirkin
2012-05-16 16:25 ` [Qemu-devel] " Michael S. Tsirkin
2012-05-16 13:20 ` Michael S. Tsirkin
2012-05-16 11:37 ` Anthony PERARD
2012-05-16 16:02 ` Anthony Liguori
2012-05-16 16:24 ` Michael S. Tsirkin
2012-05-16 16:24 ` Michael S. Tsirkin
2012-05-16 16:02 ` Anthony Liguori
2012-05-16 11:23 ` Paolo Bonzini
2012-05-16 11:15 ` [Qemu-devel] " Anthony PERARD
2012-05-15 15:26 ` [Qemu-devel] [PATCH 2/4] qdev: Introduce qdev_force_unplug Anthony PERARD
2012-05-15 15:26 ` Anthony PERARD
2012-05-15 18:15 ` [Qemu-devel] " Stefano Stabellini
2012-05-15 18:22 ` Anthony PERARD
2012-05-15 18:22 ` Anthony PERARD
2012-05-15 18:15 ` Stefano Stabellini
2012-05-15 15:26 ` [Qemu-devel] [PATCH 3/4] pci: Add force_unplug callback Anthony PERARD
2012-05-15 15:26 ` Anthony PERARD
2012-05-15 15:26 ` [Qemu-devel] [PATCH 4/4] xen: Fix PV-on-HVM Anthony PERARD
2012-05-15 15:26 ` Anthony PERARD
2012-05-15 21:00 ` Michael S. Tsirkin
2012-05-15 21:00 ` [Qemu-devel] " Michael S. Tsirkin
2012-05-16 8:06 ` Paolo Bonzini
2012-05-16 8:06 ` [Qemu-devel] " Paolo Bonzini
2012-05-16 8:13 ` Michael S. Tsirkin
2012-05-16 8:13 ` [Qemu-devel] " Michael S. Tsirkin
2012-05-16 8:42 ` Paolo Bonzini
2012-05-16 10:19 ` Stefano Stabellini
2012-05-16 10:30 ` Michael S. Tsirkin
2012-05-16 10:37 ` Stefano Stabellini
2012-05-16 13:24 ` Michael S. Tsirkin
2012-05-16 13:24 ` Michael S. Tsirkin
2012-05-16 10:37 ` Stefano Stabellini
2012-05-16 10:30 ` Michael S. Tsirkin
2012-05-16 10:19 ` Stefano Stabellini
2012-05-16 8:42 ` Paolo Bonzini
2012-05-15 16:26 ` [Qemu-devel] [PATCH 1.1 0/4] Xen: " Anthony Liguori
2012-05-15 16:42 ` Stefano Stabellini
2012-05-15 16:42 ` [Qemu-devel] " Stefano Stabellini
2012-05-15 16:26 ` Anthony Liguori
2012-05-15 18:20 ` Stefano Stabellini
2012-05-15 18:20 ` [Qemu-devel] " Stefano Stabellini
2012-05-15 21:06 ` Michael S. Tsirkin
2012-05-15 21:06 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FB3CD31.8050903@redhat.com \
--to=pbonzini@redhat.com \
--cc=anthony.perard@citrix.com \
--cc=anthony@codemonkey.ws \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.