Re: [PATCH 1/2 v2] rbd: allow importing from stdin

[Josh Durgin <josh.durgin@inktank.com>]

On 05/16/2012 04:51 PM, Tommi Virtanen wrote:
> On Wed, May 16, 2012 at 3:25 PM, Yehuda Sadeh Weinraub
> <yehudasa@gmail.com>  wrote:
>> I'd rather not pass size for stdin. We should instead make it so that
>> we don't read size at all and just importing while !eof (or do that
>> only when size is 0). We'd need to create the image with size=0 and
>> update the header in the end.
>
> Hopefully something there would prevent us from leaking objects if the
> rbd import crashed half way through. Perhaps the header needs to
> change before each object gets created?

librbd prevents you from writing beyond the bounds of an image.
If we keep that restriction, you'd need to resize the image to
have enough space for the import, and resize down to the final
size at the end.