From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] sdp4430: fix mux configuration for SYS_NIRQ2
Date: Thu, 17 May 2012 12:28:46 +0300 [thread overview]
Message-ID: <4FB4C4CE.8090506@ti.com> (raw)
In-Reply-To: <CAJ7qFSdB9i01gqnoSC=jfpXduKFZd9E3wWcCh95S=OVm9zd-Zw@mail.gmail.com>
Hi Sricharan,
On 05/17/2012 11:48 AM, R, Sricharan wrote:
>> diff --git a/board/ti/sdp4430/sdp4430_mux_data.h b/board/ti/sdp4430/sdp4430_mux_data.h
>> index 0a20968..beb7c7a 100644
>> --- a/board/ti/sdp4430/sdp4430_mux_data.h
>> +++ b/board/ti/sdp4430/sdp4430_mux_data.h
>> @@ -216,7 +216,7 @@ const struct pad_conf_entry core_padconf_array_non_essential[] = {
>> {FREF_CLK1_OUT, (M0)}, /* fref_clk1_out */
>> {FREF_CLK2_OUT, (M0)}, /* fref_clk2_out */
>> {SYS_NIRQ1, (PTU | IEN | M0)}, /* sys_nirq1 */
>> - {SYS_NIRQ2, (M7)}, /* sys_nirq2 */
>> + {SYS_NIRQ2, (PTU | IEN | M0)}, /* sys_nirq2 */
>
> Looks fine. But how about doing this in the kernel using mux framework?
The SYS_NIRQ2 has been configured correctly in case of PandaBoard in u-boot.
Looking at the kernel: neither of the sdp4430 or PandaBoard board files
are configuring SYS_NIRQ1/2, all relies on the bootloader to set this up.
I can as well send patches for sdp4430 and PandaBoard board files to
configure the SYS_NIRQ2 explicitly, but IMHO the bootloader can do this
for us with ease as well.
I think if we can we should set up things in a bootloader and let the
kernel to deal with smaller differences (like things differs between
board revisions and stuff).
Regards,
P?ter
next prev parent reply other threads:[~2012-05-17 9:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-17 8:43 [U-Boot] [PATCH] sdp4430: fix mux configuration for SYS_NIRQ2 Peter Ujfalusi
2012-05-17 8:48 ` R, Sricharan
2012-05-17 9:28 ` Peter Ujfalusi [this message]
2012-05-18 4:41 ` R, Sricharan
2012-05-18 6:46 ` Ujfalusi, Peter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FB4C4CE.8090506@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.