From mboxrd@z Thu Jan 1 00:00:00 1970 From: walter harms Date: Thu, 17 May 2012 10:06:45 +0000 Subject: Re: [patch] drm: checking the wrong variable in savage_do_init_bci() Message-Id: <4FB4CDB5.8010602@bfs.de> List-Id: References: <20120517070944.GE14660@elgon.mountain> In-Reply-To: <20120517070944.GE14660@elgon.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: Nicolas Kaiser , kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org, Dave Airlie , Greg Dietsche Am 17.05.2012 09:09, schrieb Dan Carpenter: > drm_core_ioremap() initializes ->handle. We already know > "dev->agp_buffer_map" is a valid pointer. > > Signed-off-by: Dan Carpenter > > diff --git a/drivers/gpu/drm/savage/savage_bci.c b/drivers/gpu/drm/savage/savage_bci.c > index cb1ee4e..6eb507a 100644 > --- a/drivers/gpu/drm/savage/savage_bci.c > +++ b/drivers/gpu/drm/savage/savage_bci.c > @@ -735,7 +735,7 @@ static int savage_do_init_bci(struct drm_device * dev, drm_savage_init_t * init) > return -EINVAL; > } > drm_core_ioremap(dev->agp_buffer_map, dev); > - if (!dev->agp_buffer_map) { > + if (!dev->agp_buffer_map->handle) { > DRM_ERROR("failed to ioremap DMA buffer region!\n"); > savage_do_cleanup_bci(dev); > return -ENOMEM; ok, the interface asks for that type of error :) re, wh From mboxrd@z Thu Jan 1 00:00:00 1970 From: walter harms Subject: Re: [patch] drm: checking the wrong variable in savage_do_init_bci() Date: Thu, 17 May 2012 12:06:45 +0200 Message-ID: <4FB4CDB5.8010602@bfs.de> References: <20120517070944.GE14660@elgon.mountain> Reply-To: wharms@bfs.de Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx01.sz.bfs.de (mx01.sz.bfs.de [194.94.69.103]) by gabe.freedesktop.org (Postfix) with ESMTP id 3FD509E73D for ; Thu, 17 May 2012 03:06:49 -0700 (PDT) In-Reply-To: <20120517070944.GE14660@elgon.mountain> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Dan Carpenter Cc: Nicolas Kaiser , kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org, Dave Airlie , Greg Dietsche List-Id: dri-devel@lists.freedesktop.org Am 17.05.2012 09:09, schrieb Dan Carpenter: > drm_core_ioremap() initializes ->handle. We already know > "dev->agp_buffer_map" is a valid pointer. > > Signed-off-by: Dan Carpenter > > diff --git a/drivers/gpu/drm/savage/savage_bci.c b/drivers/gpu/drm/savage/savage_bci.c > index cb1ee4e..6eb507a 100644 > --- a/drivers/gpu/drm/savage/savage_bci.c > +++ b/drivers/gpu/drm/savage/savage_bci.c > @@ -735,7 +735,7 @@ static int savage_do_init_bci(struct drm_device * dev, drm_savage_init_t * init) > return -EINVAL; > } > drm_core_ioremap(dev->agp_buffer_map, dev); > - if (!dev->agp_buffer_map) { > + if (!dev->agp_buffer_map->handle) { > DRM_ERROR("failed to ioremap DMA buffer region!\n"); > savage_do_cleanup_bci(dev); > return -ENOMEM; ok, the interface asks for that type of error :) re, wh