From mboxrd@z Thu Jan 1 00:00:00 1970 From: Glauber Costa Subject: Re: [PATCH v2 02/29] slub: fix slab_state for slub Date: Thu, 17 May 2012 14:14:18 +0400 Message-ID: <4FB4CF7A.9090108@parallels.com> References: <1336758272-24284-1-git-send-email-glommer@parallels.com> <1336758272-24284-3-git-send-email-glommer@parallels.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii"; format="flowed" To: David Rientjes Cc: Pekka Enberg , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, KAMEZAWA Hiroyuki , Tejun Heo , Li Zefan , Greg Thelen , Suleiman Souhlal , Michal Hocko , Johannes Weiner , devel-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org, Christoph Lameter On 05/16/2012 01:55 AM, David Rientjes wrote: > On Fri, 11 May 2012, Glauber Costa wrote: > >> When the slub code wants to know if the sysfs state has already been >> initialized, it tests for slab_state == SYSFS. This is quite fragile, >> since new state can be added in the future (it is, in fact, for >> memcg caches). This patch fixes this behavior so the test matches >>> = SYSFS, as all other state does. >> >> Signed-off-by: Glauber Costa > > Acked-by: David Rientjes > > Can be merged now, there's no dependency on the rest of this patchset. So, is anyone taking this? I plan another submission this week, let me know if I should include these two patches or not. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx104.postini.com [74.125.245.104]) by kanga.kvack.org (Postfix) with SMTP id 34B7E6B0044 for ; Thu, 17 May 2012 06:16:30 -0400 (EDT) Message-ID: <4FB4CF7A.9090108@parallels.com> Date: Thu, 17 May 2012 14:14:18 +0400 From: Glauber Costa MIME-Version: 1.0 Subject: Re: [PATCH v2 02/29] slub: fix slab_state for slub References: <1336758272-24284-1-git-send-email-glommer@parallels.com> <1336758272-24284-3-git-send-email-glommer@parallels.com> In-Reply-To: Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: David Rientjes Cc: Pekka Enberg , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, KAMEZAWA Hiroyuki , Tejun Heo , Li Zefan , Greg Thelen , Suleiman Souhlal , Michal Hocko , Johannes Weiner , devel@openvz.org, Christoph Lameter On 05/16/2012 01:55 AM, David Rientjes wrote: > On Fri, 11 May 2012, Glauber Costa wrote: > >> When the slub code wants to know if the sysfs state has already been >> initialized, it tests for slab_state == SYSFS. This is quite fragile, >> since new state can be added in the future (it is, in fact, for >> memcg caches). This patch fixes this behavior so the test matches >>> = SYSFS, as all other state does. >> >> Signed-off-by: Glauber Costa > > Acked-by: David Rientjes > > Can be merged now, there's no dependency on the rest of this patchset. So, is anyone taking this? I plan another submission this week, let me know if I should include these two patches or not. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761551Ab2EQKQZ (ORCPT ); Thu, 17 May 2012 06:16:25 -0400 Received: from mx2.parallels.com ([64.131.90.16]:44352 "EHLO mx2.parallels.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761523Ab2EQKQX (ORCPT ); Thu, 17 May 2012 06:16:23 -0400 Message-ID: <4FB4CF7A.9090108@parallels.com> Date: Thu, 17 May 2012 14:14:18 +0400 From: Glauber Costa User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120216 Thunderbird/10.0.1 MIME-Version: 1.0 To: David Rientjes CC: Pekka Enberg , , , , KAMEZAWA Hiroyuki , Tejun Heo , Li Zefan , Greg Thelen , Suleiman Souhlal , Michal Hocko , Johannes Weiner , , Christoph Lameter Subject: Re: [PATCH v2 02/29] slub: fix slab_state for slub References: <1336758272-24284-1-git-send-email-glommer@parallels.com> <1336758272-24284-3-git-send-email-glommer@parallels.com> In-Reply-To: Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/16/2012 01:55 AM, David Rientjes wrote: > On Fri, 11 May 2012, Glauber Costa wrote: > >> When the slub code wants to know if the sysfs state has already been >> initialized, it tests for slab_state == SYSFS. This is quite fragile, >> since new state can be added in the future (it is, in fact, for >> memcg caches). This patch fixes this behavior so the test matches >>> = SYSFS, as all other state does. >> >> Signed-off-by: Glauber Costa > > Acked-by: David Rientjes > > Can be merged now, there's no dependency on the rest of this patchset. So, is anyone taking this? I plan another submission this week, let me know if I should include these two patches or not.