From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Yong Zhang <yong.zhang0@gmail.com>
Cc: linux-mips@linux-mips.org, linux-kernel@vger.kernel.org,
ralf@linux-mips.org, david.daney@cavium.com
Subject: Re: [PATCH 7/8] MIPS: smp: Warn on too early irq enable
Date: Thu, 17 May 2012 14:55:12 +0400 [thread overview]
Message-ID: <4FB4D910.3020905@mvista.com> (raw)
In-Reply-To: <1337249410-7162-8-git-send-email-yong.zhang0@gmail.com>
Hello.
On 17-05-2012 14:10, Yong Zhang wrote:
> From: Yong Zhang<yong.zhang@windriver.com>
> Just to catch a potential issue.
Grammar nitpicking ahead. :-)
> Signed-off-by: Yong Zhang<yong.zhang0@gmail.com>
> ---
> arch/mips/kernel/smp.c | 5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
> diff --git a/arch/mips/kernel/smp.c b/arch/mips/kernel/smp.c
> index 042145f..0d48598 100644
> --- a/arch/mips/kernel/smp.c
> +++ b/arch/mips/kernel/smp.c
> @@ -130,6 +130,11 @@ asmlinkage __cpuinit void start_secondary(void)
>
> synchronise_count_slave();
>
> + /*
> + * irq will be enabled in ->smp_finish(), enable it too early
s/enable/enabling/
WBR, Sergei
next prev parent reply other threads:[~2012-05-17 10:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-17 10:10 [PATCH 0/8] patchset focus on MIPS SMP woes Yong Zhang
2012-05-17 10:10 ` [PATCH 1/8] MIPS: Octeon: delay enable irq to ->smp_finish() Yong Zhang
2012-05-17 10:10 ` [PATCH 2/8] MIPS: BMIPS: delay irq enable " Yong Zhang
2012-05-17 10:10 ` [PATCH 3/8] MIPS: SMTC: " Yong Zhang
2012-05-17 10:10 ` [PATCH 4/8] MIPS: Yosemite: " Yong Zhang
2012-05-17 10:10 ` [PATCH 5/8] MIPS: call ->smp_finish() a little late Yong Zhang
2012-05-17 10:10 ` [PATCH 6/8] MIPS: call set_cpu_online() on the uping cpu with irq disabled Yong Zhang
2012-05-17 10:59 ` Sergei Shtylyov
2012-05-17 10:10 ` [PATCH 7/8] MIPS: smp: Warn on too early irq enable Yong Zhang
2012-05-17 10:55 ` Sergei Shtylyov [this message]
2012-05-17 10:10 ` [PATCH 8/8] MIPS: sync-r4k: remove redundant irq operation Yong Zhang
2012-05-17 16:13 ` [PATCH 0/8] patchset focus on MIPS SMP woes David Daney
2012-05-17 17:56 ` Sergei Shtylyov
-- strict thread matches above, loose matches on Subject: below --
2012-05-21 6:00 [V1 PATCH " Yong Zhang
2012-05-21 6:00 ` [PATCH 7/8] MIPS: smp: Warn on too early irq enable Yong Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FB4D910.3020905@mvista.com \
--to=sshtylyov@mvista.com \
--cc=david.daney@cavium.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=yong.zhang0@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.