From: Roger Pau Monne <roger.pau@citrix.com>
To: Christoph Egger <Christoph.Egger@amd.com>
Cc: "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH] libxl: build fix
Date: Thu, 17 May 2012 12:41:25 +0100 [thread overview]
Message-ID: <4FB4E3E5.4090600@citrix.com> (raw)
In-Reply-To: <4FB3CD0E.5000708@amd.com>
Christoph Egger wrote:
> Fix this build error:
>
> libxl_aoutils.c: In function 'libxl__openptys':
> libxl_aoutils.c:281:13: error: passing argument 4 of 'openpty' discards
> qualifiers from pointer target type
> /usr/include/util.h:92:6: note: expected 'struct termios *' but argument
> is of type 'const struct termios *'
> libxl_aoutils.c:281:13: error: passing argument 5 of 'openpty' discards
> qualifiers from pointer target type
> /usr/include/util.h:92:6: note: expected 'struct winsize *' but argument
> is of type 'const struct winsize *'
>
> Signed-off-by: Christoph Egger<Christoph.Egger@amd.com>
Acked-by: Roger Pau Monne <roger.pau@citrix.com>
I've tested this on both NetBSD and Debian, and it fixes the problem,
without introducing new ones. It's strange because these are BSD
functions, but Linux implementation change the parameters...
next prev parent reply other threads:[~2012-05-17 11:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-16 15:51 [PATCH] libxl: build fix Christoph Egger
2012-05-17 11:41 ` Roger Pau Monne [this message]
2012-05-17 11:44 ` Ian Campbell
2012-05-17 13:47 ` Ian Campbell
-- strict thread matches above, loose matches on Subject: below --
2011-01-11 14:54 Christoph Egger
2011-01-11 18:44 ` Ian Jackson
2010-04-13 10:16 Christoph Egger
2010-04-13 11:21 ` Ian Jackson
2010-04-13 11:49 ` Christoph Egger
2010-04-13 15:04 ` Ian Jackson
2010-04-14 7:19 ` Christoph Egger
2009-12-01 14:40 Christoph Egger
2009-12-04 15:52 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FB4E3E5.4090600@citrix.com \
--to=roger.pau@citrix.com \
--cc=Christoph.Egger@amd.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.