All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Emelyanov <xemul@parallels.com>
To: Cyrill Gorcunov <gorcunov@openvz.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	James Bottomley <jbottomley@parallels.com>,
	"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>
Subject: Re: [rfc 2/4] procfs: Convert /proc/pid/fdinfo/fd handling routines into seq-file with fdinfo helpers
Date: Thu, 17 May 2012 20:32:04 +0400	[thread overview]
Message-ID: <4FB52804.8090004@parallels.com> (raw)
In-Reply-To: <20120517162534.681059644@openvz.org>

On 05/17/2012 08:07 PM, Cyrill Gorcunov wrote:
> This patch converts /proc/pid/fdinfo/fd handling routines to seq-files with
> ability to plug in additional fdinfo helpers from other subsystems.
> 
> For example files created in eventfd/eventpoll/inotify subsystems might print
> out additional information, not just file position and flags.
> 
> Still if there no fdinfo helpers registered then the output is well known
> pos, flags pair.
> 
> Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>

I would split this into two parts -- the 1st one turns fdinfo into seq-files
and the 2nd one adds the fdinfo helpers. This will make the review MUCH simpler.

Thanks,
Pavel

  reply	other threads:[~2012-05-17 16:32 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-17 16:07 [rfc 0/4] procfs fdinfo extension Cyrill Gorcunov
2012-05-17 16:07 ` [rfc 1/4] procfs: Move /proc/pid/fd[info] handling code to fd.[ch] Cyrill Gorcunov
2012-05-17 16:07 ` [rfc 2/4] procfs: Convert /proc/pid/fdinfo/fd handling routines into seq-file with fdinfo helpers Cyrill Gorcunov
2012-05-17 16:32   ` Pavel Emelyanov [this message]
2012-05-17 17:38     ` Cyrill Gorcunov
2012-05-17 21:49       ` Cyrill Gorcunov
2012-05-17 16:07 ` [rfc 3/4] fs, eventfd: Add procfs fdinfo helper Cyrill Gorcunov
2012-05-17 16:34   ` Pavel Emelyanov
2012-05-17 17:43     ` Cyrill Gorcunov
2012-05-17 16:07 ` [rfc 4/4] fs, epoll: " Cyrill Gorcunov
2012-05-17 16:29 ` [rfc 0/4] procfs fdinfo extension Pavel Emelyanov
2012-05-17 19:05 ` Andrew Morton
2012-05-17 19:28   ` Cyrill Gorcunov
2012-05-18 11:53   ` Pavel Emelyanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FB52804.8090004@parallels.com \
    --to=xemul@parallels.com \
    --cc=akpm@linux-foundation.org \
    --cc=gorcunov@openvz.org \
    --cc=jbottomley@parallels.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.