From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Romanick Date: Thu, 17 May 2012 17:05:43 +0000 Subject: Re: [patch] drm: checking the wrong variable in savage_do_init_bci() Message-Id: <4FB52FE7.6070303@freedesktop.org> List-Id: References: <20120517070944.GE14660@elgon.mountain> In-Reply-To: <20120517070944.GE14660@elgon.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: Nicolas Kaiser , kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org, Dave Airlie , Greg Dietsche On 05/17/2012 12:09 AM, Dan Carpenter wrote: > drm_core_ioremap() initializes ->handle. We already know > "dev->agp_buffer_map" is a valid pointer. > > Signed-off-by: Dan Carpenter I'm surprised that has never been hit. Reviewed-by: Ian Romanick > > diff --git a/drivers/gpu/drm/savage/savage_bci.c b/drivers/gpu/drm/savage/savage_bci.c > index cb1ee4e..6eb507a 100644 > --- a/drivers/gpu/drm/savage/savage_bci.c > +++ b/drivers/gpu/drm/savage/savage_bci.c > @@ -735,7 +735,7 @@ static int savage_do_init_bci(struct drm_device * dev, drm_savage_init_t * init) > return -EINVAL; > } > drm_core_ioremap(dev->agp_buffer_map, dev); > - if (!dev->agp_buffer_map) { > + if (!dev->agp_buffer_map->handle) { > DRM_ERROR("failed to ioremap DMA buffer region!\n"); > savage_do_cleanup_bci(dev); > return -ENOMEM; > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Romanick Subject: Re: [patch] drm: checking the wrong variable in savage_do_init_bci() Date: Thu, 17 May 2012 10:05:43 -0700 Message-ID: <4FB52FE7.6070303@freedesktop.org> References: <20120517070944.GE14660@elgon.mountain> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from expn.cat.pdx.edu (expn.cat.pdx.edu [131.252.208.110]) by gabe.freedesktop.org (Postfix) with ESMTP id BB4929F512 for ; Thu, 17 May 2012 10:06:38 -0700 (PDT) In-Reply-To: <20120517070944.GE14660@elgon.mountain> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Dan Carpenter Cc: Nicolas Kaiser , kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org, Dave Airlie , Greg Dietsche List-Id: dri-devel@lists.freedesktop.org On 05/17/2012 12:09 AM, Dan Carpenter wrote: > drm_core_ioremap() initializes ->handle. We already know > "dev->agp_buffer_map" is a valid pointer. > > Signed-off-by: Dan Carpenter I'm surprised that has never been hit. Reviewed-by: Ian Romanick > > diff --git a/drivers/gpu/drm/savage/savage_bci.c b/drivers/gpu/drm/savage/savage_bci.c > index cb1ee4e..6eb507a 100644 > --- a/drivers/gpu/drm/savage/savage_bci.c > +++ b/drivers/gpu/drm/savage/savage_bci.c > @@ -735,7 +735,7 @@ static int savage_do_init_bci(struct drm_device * dev, drm_savage_init_t * init) > return -EINVAL; > } > drm_core_ioremap(dev->agp_buffer_map, dev); > - if (!dev->agp_buffer_map) { > + if (!dev->agp_buffer_map->handle) { > DRM_ERROR("failed to ioremap DMA buffer region!\n"); > savage_do_cleanup_bci(dev); > return -ENOMEM; > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel >