From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1SVBtF-0002iB-A4 for mharc-grub-devel@gnu.org; Thu, 17 May 2012 21:21:57 -0400 Received: from eggs.gnu.org ([208.118.235.92]:50591) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SVBtD-0002ho-2T for grub-devel@gnu.org; Thu, 17 May 2012 21:21:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SVBtB-0003bN-8W for grub-devel@gnu.org; Thu, 17 May 2012 21:21:54 -0400 Received: from mail-pz0-f41.google.com ([209.85.210.41]:41931) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SVBtA-0003b8-Vp for grub-devel@gnu.org; Thu, 17 May 2012 21:21:53 -0400 Received: by dakp5 with SMTP id p5so3403018dak.0 for ; Thu, 17 May 2012 18:21:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=+EUozCGe3JRNoP8XkDRoAWcVwAZ4Umw8RJxEcpwRG3E=; b=HzgjDTfyqNQpcVTgd2bVO0PKMaNRQMc9c9+zGrxaCIL0fQ7x2KQ+qVivbWVupn74nh dUHLOUBuuOvlXsPFi7QXma0CWFJ1CNGXI9MyV9Y/a9PkFwfXFVQybRO4L+8yt5sZX2hU JTRzqNTkWOF1RYzLcUkuWB1I0J8h5K5MyJlMjBXxiF0gwExNnrIDLJ0i7GVV9oBedRVN w0v4kcwMvPPCztOwoJ/BmFF4+qt9KHo3PXgO/p/ZzqQ2W4YhnFqSt9jayOUTrLHIY7iL XqKPxUuRpEfv2b2IXD95SZSN1H8R5Ws2C4g/LNg4WDvHwVXYD9fwtgp72t8MK7pAsuRf dATg== Received: by 10.68.216.73 with SMTP id oo9mr32653131pbc.80.1337304109685; Thu, 17 May 2012 18:21:49 -0700 (PDT) Received: from [192.168.1.2] ([216.57.70.194]) by mx.google.com with ESMTPS id h10sm10884254pbh.69.2012.05.17.18.21.47 (version=SSLv3 cipher=OTHER); Thu, 17 May 2012 18:21:48 -0700 (PDT) Message-ID: <4FB5A42B.5000208@gmail.com> Date: Thu, 17 May 2012 18:21:47 -0700 From: Jordan Uggla User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 MIME-Version: 1.0 To: The development of GNU GRUB Subject: Re: [PATCH] Boot immediately after GRUB_HIDDEN_TIMEOUT References: <4F9D9328.9080303@kiilerich.com> In-Reply-To: <4F9D9328.9080303@kiilerich.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.85.210.41 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 May 2012 01:21:56 -0000 On 04/29/2012 12:14 PM, Mads Kiilerich wrote: > * util/grub.d/00_header.in: Boot immediately after > GRUB_HIDDEN_TIMEOUT. Documentation said: "If no key is pressed > during that time, boot immediately." > > > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel I don't see anything wrong with the current handling of GRUB_HIDDEN_TIMEOUT and GRUB_TIMEOUT in grub-mkconfig other than it contradicting the documentation. I would rather fix the documentation and avoid any possible issues with grub's behavior changing for existing configurations with regard to these variables upon upgrading to grub 2.00. Below is a patch which fixes the documentation in grub.texi. -- Jordan Uggla (Jordan_U on irc.freenode.net) === modified file 'ChangeLog' --- ChangeLog 2012-05-15 15:17:06 +0000 +++ ChangeLog 2012-05-18 01:07:20 +0000 @@ -1,3 +1,10 @@ +2012-05-17 Jordan Uggla + + * docs/grub.texi Fix documentation of GRUB_HIDDEN_TIMOUNT to match the + actual implementation. Specifically, clarify that the grub menu will + be displayed for GRUB_TIMOUT seconds after the hidden timeout has + passed. + 2012-05-15 Vladimir Serbinenko * grub-core/fs/ntfs.c (read_data): Prevent overflow. === modified file 'docs/grub.texi' --- docs/grub.texi 2012-05-03 22:28:53 +0000 +++ docs/grub.texi 2012-05-18 00:49:41 +0000 @@ -1135,7 +1135,11 @@ @item GRUB_HIDDEN_TIMEOUT Wait this many seconds for a key to be pressed before displaying the menu. -If no key is pressed during that time, boot immediately. Unset by default. +If no key is pressed during that time, display the menu for the number of +seconds specified in GRUB_TIMEOUT before booting the default entry. We expect +that most people who use GRUB_HIDDEN_TIMEOUT will want to have GRUB_TIMEOUT set +to @samp{0} so that the menu is not displayed at all unless a key is pressed. +Unset by default. @item GRUB_HIDDEN_TIMEOUT_QUIET In conjunction with @samp{GRUB_HIDDEN_TIMEOUT}, set this to @samp{true} to