From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:47864) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SVJZg-000877-K6 for qemu-devel@nongnu.org; Fri, 18 May 2012 05:34:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SVJZa-0000dP-Fs for qemu-devel@nongnu.org; Fri, 18 May 2012 05:34:16 -0400 Received: from cantor2.suse.de ([195.135.220.15]:55215 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SVJZa-0000cx-94 for qemu-devel@nongnu.org; Fri, 18 May 2012 05:34:10 -0400 Message-ID: <4FB61788.6060703@suse.de> Date: Fri, 18 May 2012 11:34:00 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1337016729-12285-1-git-send-email-afaerber@suse.de> <1337016729-12285-13-git-send-email-afaerber@suse.de> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH qom-next 12/22] xilinx_zynq: Use cpu_arm_init() to obtain ARMCPU List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Peter Crosthwaite , qemu-devel@nongnu.org Am 15.05.2012 13:08, schrieb Peter Maydell: > On 14 May 2012 18:31, Andreas F=C3=A4rber wrote: >> The board initializes only one CPU, so replace first_cpu with that CPU= 's >> state to facilitate review of arm_load_kernel() signature change and t= o >> avoid double casts then. >=20 > There was a patch proposed to add SMP support to this board: > http://lists.gnu.org/archive/html/qemu-devel/2012-04/msg00047.html >=20 > I dunno whether that changes the best thing to do in this patch. Thanks for pointing me to this. From what I see that series has open issues and was not applied to target-arm.next yet, right? In that case I can't rebase my patches on top of it, but I get that touching first_cpu here is not a good idea for SMP. I'll apply the preceding patches and will respin with arm_env_get_cpu(first_cpu) in 15/22. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg