Re: [PATCH v2 3/4] python: set absolute path to libxl.h on _pyxl_types.c

[Roger Pau Monne <roger.pau@citrix.com>]

Ian Jackson wrote:
> Roger Pau Monne writes ("[PATCH v2 3/4] python: set absolute path to libxl.h on _pyxl_types.c"):
>> genwrap.py generates _pyxl_types.c, which includes libxl.h, but if
>> libxl.h is already present in the include search path, the old one was
>> included instead of the new one, giving compilation errors. Since
>> _pyxl_types.c is generated at compilation time, we can safely set
>> the path to libxl.h include.
>
> I'm not sure what you mean by "the old one".  Do you mean one in
> /usr/include ?

Yes, in NetBSD case the ones in /usr/pkg/include, that's where Xen 
headers would reside on a normal installation.

>
>> I've only experienced this problem when compiling Xen on NetBSD with
>> old header files in the include path, Linux seems to not have this
>> problem.
>
> The build system should make sure that our own include directories
> come before system directories.  Otherwise various other things aren't
> going to work either.

This only happened when building python extensions because the port 
build of python passes "OPT" to python configure that contains 
-I/usr/pkg/include. And that is used also when building extensions. A 
bug report is in place. The rest of the build system is fine.

> Ian.