From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roger Pau Monne Subject: Re: [PATCH v2 4/4] tools/build: change order of config/Tools.mk inclusion Date: Fri, 18 May 2012 12:59:47 +0100 Message-ID: <4FB639B3.3000905@citrix.com> References: <1337256990-51913-1-git-send-email-roger.pau@citrix.com> <1337256990-51913-4-git-send-email-roger.pau@citrix.com> <20406.12213.751409.867469@mariner.uk.xensource.com> <4FB632A6.4000403@citrix.com> <20406.13989.715688.280631@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20406.13989.715688.280631@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: Christoph Egger , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org Ian Jackson wrote: > Roger Pau Monne writes ("Re: [PATCH v2 4/4] tools/build: change order of config/Tools.mk inclusion"): >> Ian Jackson wrote: >>> Also PREFIX is set in StdGNU.mk. Why is it also set in Tools.mk ? >> Configure scripts have a very common option, --prefix, which is saved >> into Tools.mk as PREFIX, this is what should be used as prefix for >> installation. > > I know that. But given that the configure is just for the tools > build, should we honour PREFIX from Config.mk (and ./.config or > command line arguments) or from ./configure ? I think the one from configure, since we have a configure script, better make use of it, that is what users expect. I will resend this patch with the above changes to config/Linux.mk, is that ok?