From: Rob Evers <revers@redhat.com>
To: "Moger, Babu" <Babu.Moger@netapp.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH 2/3] alua: retry alua rtpg extended header for illegal request response
Date: Fri, 18 May 2012 08:34:15 -0400 [thread overview]
Message-ID: <4FB641C7.5040709@redhat.com> (raw)
In-Reply-To: <4FB5AD44.2030705@redhat.com>
On 05/17/2012 10:00 PM, Rob Evers wrote:
> On 05/17/2012 05:02 PM, Moger, Babu wrote:
>
>>> + * handles this.
>>> + */
>>> + if (sense_hdr.sense_key == ILLEGAL_REQUEST&&
>>> + sense_hdr.asc == 0x24&& sense_hdr.ascq == 0) {
>>> + rtpg_ext_hdr_req = 0;
>>> + goto retry;
>> We should probably have an exit criteria here. What if target
>> misbehaves
>> (with ILLEGAL_REQUEST) even with rtpg_ext_hdr_req = 0.
>
> Do you have a more detailed suggestion on the
> exit criteria?
>
Yes I got your point. I'll repost.
next prev parent reply other threads:[~2012-05-18 12:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-16 14:15 [PATCH 1/3] alua: implement 'implied transition timeout' Rob Evers
2012-05-16 14:15 ` [PATCH 2/3] alua: retry alua rtpg extended header for illegal request response Rob Evers
2012-05-17 21:02 ` Moger, Babu
2012-05-18 2:00 ` Rob Evers
2012-05-18 12:34 ` Rob Evers [this message]
2012-05-16 14:15 ` [PATCH 3/3] alua: backoff alua rtpg retry linearly vs. geometrically Rob Evers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FB641C7.5040709@redhat.com \
--to=revers@redhat.com \
--cc=Babu.Moger@netapp.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.