From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-bk0-f46.google.com ([209.85.214.46]:47900 "EHLO mail-bk0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761606Ab2ERN0T (ORCPT ); Fri, 18 May 2012 09:26:19 -0400 Received: by bkcji2 with SMTP id ji2so2349258bkc.19 for ; Fri, 18 May 2012 06:26:18 -0700 (PDT) Message-ID: <4FB64DF6.6080903@gmail.com> Date: Fri, 18 May 2012 15:26:14 +0200 From: poma MIME-Version: 1.0 To: Antti Palosaari , Thomas Mair , linux-media@vger.kernel.org Subject: Re: [PATCH v4 1/5] rtl2832 ver. 0.4: removed signal statistics References: <1337206420-23810-1-git-send-email-thomas.mair86@googlemail.com> <1337206420-23810-2-git-send-email-thomas.mair86@googlemail.com> <4FB50909.7030101@iki.fi> <4FB59E03.7080800@gmail.com> <4FB61328.3090707@gmail.com> <4FB62695.3030909@gmail.com> <4FB642D3.2010903@iki.fi> In-Reply-To: <4FB642D3.2010903@iki.fi> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-media-owner@vger.kernel.org List-ID: On 05/18/2012 02:38 PM, Antti Palosaari wrote: > On 18.05.2012 13:38, poma wrote: >> […] >> >> printk(KERN_ERR LOG_PREFIX": " f "\n" , ## arg) >> pr_err(LOG_PREFIX": " f "\n" , ## arg) >> >> printk(KERN_INFO LOG_PREFIX": " f "\n" , ## arg) >> pr_info(LOG_PREFIX": " f "\n" , ## arg) >> >> printk(KERN_WARNING LOG_PREFIX": " f "\n" , ## arg) >> pr_warn(LOG_PREFIX": " f "\n" , ## arg) >> >> Besides what 'checkpatch' suggest/output - Antti, is it a correct >> conversions? > > > I haven't looked those pr_err/pr_info/pr_warn, but what I did for > af9035/af9033 was I used pr_debug as a debug writings since it seems to > be choice of today. > > I still suspect those pr_* functions should be used instead own macros. > Currently documentation mentions only pr_debug and pr_info. > > regards > Antit OK, thanks Antti! Thomas, dropping 'rtl2832_priv.h.diff' & 'rtl2832_priv.h-v2.diff' Please leave 'rtl2832_priv.h' as it is. And there you go… cheers, poma