All of lore.kernel.org
 help / color / mirror / Atom feed
From: Timur Tabi <b04825@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 5/6] cmd_nvedit.c: allow board-specific code before/after saving the environment
Date: Fri, 18 May 2012 11:17:38 -0500	[thread overview]
Message-ID: <4FB67622.3030803@freescale.com> (raw)
In-Reply-To: <4FB6752A.5080309@freescale.com>

Scott Wood wrote:

> That's the equivalent of saying Linux doesn't support something because
> nobody bothered to enable it in a certain defconfig.

Well, that's exactly what I meant.  When you boot an upstream U-boot on a
P1022DS, there is no support for NAND chips.  The 'nand' command does not
exist.  You cannot build a u-boot.bin that will boot from NAND.  That
pretty much means "there is no NAND support".

>>>>> However, I just tried the two SDK patches 
>>>>> that add it, and they apply cleanly, so that's an easy fix.
>>> Which patches are those?
>>
>>     powerpc/85xx: add SPI and SD builds for P1022DS
>>     powerpc/p1022ds: Add support for NAND and NAND boot
> 
> I'm not sure what SPI and SD have to do with it...

The 2nd patch applies on top of the first.

> Most of the latter patch is concerned with NAND boot, which is a
> different issue from NAND support, but still pretty important if you're
> going NAND-only.  It looks like the patches were actually initially
> separate, but Kumar oh-so-helpfully squashed them together.

It's a good thing we don't do that any more.

> One thing I would like to see fixed in at upstream version of p1022ds
> NAND boot support is for it to use SPD like a normal p1022ds boot.  This
> will likely require reviving the three-stage boot discussion (TPL).

I just posted those two patches for upstream.  I don't want the TPL work
to hold up these patches.

-- 
Timur Tabi
Linux kernel developer at Freescale

  reply	other threads:[~2012-05-18 16:17 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-04 22:21 [U-Boot] [PATCH 1/6] powerpc/85xx: minor clean-ups to the P2020DS board header file Timur Tabi
2012-05-04 22:21 ` [U-Boot] [PATCH 2/6] powerpc/85xx: fdt_set_phy_handle() should return an error code Timur Tabi
2012-05-04 22:21 ` [U-Boot] [PATCH 3/6] powerpc/85xx: clean up P1022DS board configuration header file Timur Tabi
2012-05-04 22:21 ` [U-Boot] [PATCH 4/6] lib/powerpc: addrmap_phys_to_virt() should return a pointer Timur Tabi
2012-05-04 22:21 ` [U-Boot] [PATCH 5/6] cmd_nvedit.c: allow board-specific code before/after saving the environment Timur Tabi
2012-05-14  5:20   ` Mike Frysinger
2012-05-14 16:10     ` Timur Tabi
2012-05-15  5:14       ` Mike Frysinger
2012-05-17 22:18       ` Wolfgang Denk
2012-05-17 22:35         ` Timur Tabi
2012-05-18  2:46           ` Mike Frysinger
2012-05-18 11:28           ` Wolfgang Denk
2012-05-18 15:58             ` Timur Tabi
2012-05-18 16:02               ` Jeroen Hofstee
2012-05-18 18:24                 ` Wolfgang Denk
2012-05-18 18:23               ` Wolfgang Denk
2012-05-18 18:29               ` Fabio Estevam
2012-05-17 22:48         ` Scott Wood
2012-05-17 22:53           ` Timur Tabi
2012-05-18  2:14             ` Scott Wood
2012-05-18  2:21               ` Tabi Timur-B04825
2012-05-18  2:30                 ` Scott Wood
2012-05-18 16:00                   ` Timur Tabi
2012-05-18 16:13                     ` Scott Wood
2012-05-18 16:17                       ` Timur Tabi [this message]
2012-05-18 16:29                         ` Scott Wood
2012-05-18 17:08                           ` Timur Tabi
2012-05-18 17:21                             ` Scott Wood
2012-05-18 18:13                               ` McClintock Matthew-B29882
2012-05-18 18:28                           ` Wolfgang Denk
2012-05-17 21:18     ` Timur Tabi
2012-05-04 22:21 ` [U-Boot] [PATCH 6/6] powerpc/85xx: p1022ds: use the saveenv board preparation functions Timur Tabi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FB67622.3030803@freescale.com \
    --to=b04825@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.