From: Michael Haggerty <mhagger@alum.mit.edu>
To: mhagger@alum.mit.edu
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH 0/2] Fix some constness errors in fetch-pack
Date: Sat, 19 May 2012 16:05:07 +0200 [thread overview]
Message-ID: <4FB7A893.8080109@alum.mit.edu> (raw)
In-Reply-To: <1335955259-15309-1-git-send-email-mhagger@alum.mit.edu>
On 05/02/2012 12:40 PM, mhagger@alum.mit.edu wrote:
> From: Michael Haggerty<mhagger@alum.mit.edu>
>
> Fix some constness errors that I noticed while reading the code in
> builtin/fetch-pack.c.
>
> Michael Haggerty (2):
> cmd_fetch_pack(): declare dest to be const
> cmd_fetch_pack(): fix constness problem and memory leak
>
> builtin/fetch-pack.c | 152 +++++++++++++++++++++++++-------------------------
> 1 file changed, 77 insertions(+), 75 deletions(-)
I think that these patches got dropped because of an inconclusive
discussion [1]: Duy suggested converting the code for fetch-pack to use
parse_options(), which idea Junio didn't like. But I think that any
objections were raised against these two patches, which are just simple
cleanups.
Michael
[1] http://comments.gmane.org/gmane.comp.version-control.git/196797
--
Michael Haggerty
mhagger@alum.mit.edu
http://softwareswirl.blogspot.com/
prev parent reply other threads:[~2012-05-19 14:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-02 10:40 [PATCH 0/2] Fix some constness errors in fetch-pack mhagger
2012-05-02 10:40 ` [PATCH 1/2] cmd_fetch_pack(): declare dest to be const mhagger
2012-05-02 10:40 ` [PATCH 2/2] cmd_fetch_pack(): fix constness problem and memory leak mhagger
2012-05-02 11:14 ` Nguyen Thai Ngoc Duy
2012-05-02 13:35 ` Michael Haggerty
2012-05-02 14:38 ` [PATCH 0/3] Fix some constness errors in fetch-pack and parseopt conversion Nguyễn Thái Ngọc Duy
2012-05-02 14:38 ` [PATCH 1/3] cmd_fetch_pack(): declare dest to be const Nguyễn Thái Ngọc Duy
2012-05-02 14:38 ` [PATCH 2/3] fetch-pack: use parse_options() Nguyễn Thái Ngọc Duy
2012-05-02 14:38 ` [PATCH 3/3] cmd_fetch_pack(): fix constness problem and memory leak Nguyễn Thái Ngọc Duy
2012-05-02 17:14 ` [PATCH 2/2] " Junio C Hamano
2012-05-21 1:47 ` Junio C Hamano
2012-05-21 8:13 ` Michael Haggerty
2012-05-19 14:05 ` Michael Haggerty [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FB7A893.8080109@alum.mit.edu \
--to=mhagger@alum.mit.edu \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.