From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Sun, 20 May 2012 15:21:43 +0200 (CEST) Received: from nbd.name ([46.4.11.11]:35147 "EHLO nbd.name" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S1903546Ab2ETNVh (ORCPT ); Sun, 20 May 2012 15:21:37 +0200 Message-ID: <4FB8EFD2.3080603@openwrt.org> Date: Sun, 20 May 2012 15:21:22 +0200 From: John Crispin User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.24) Gecko/20111114 Icedove/3.1.16 MIME-Version: 1.0 To: John Crispin CC: Ralf Baechle , linux-mips@linux-mips.org, Thomas Langer , spi-devel-general@lists.sourceforge.net Subject: Re: [PATCH V4 16/17] SPI: MIPS: lantiq: add FALCON spi driver References: <1337520014-28787-1-git-send-email-blogic@openwrt.org> In-Reply-To: <1337520014-28787-1-git-send-email-blogic@openwrt.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-archive-position: 33385 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: blogic@openwrt.org Precedence: bulk X-list: linux-mips Return-Path: On 20/05/12 15:20, John Crispin wrote: > + master->mode_bits = SPI_MODE_3; > + master->num_chipselect = 1; > + master->bus_num = -1; once > + master->setup = falcon_sflash_setup; > + master->prepare_transfer_hardware = falcon_sflash_prepare_xfer; > + master->transfer_one_message = falcon_sflash_xfer_one; > + master->unprepare_transfer_hardware = falcon_sflash_unprepare_xfer; > + master->dev.of_node = pdev->dev.of_node; > + master->bus_num = -1; twice :-) sorry .... From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Crispin Subject: Re: [PATCH V4 16/17] SPI: MIPS: lantiq: add FALCON spi driver Date: Sun, 20 May 2012 15:21:22 +0200 Message-ID: <4FB8EFD2.3080603@openwrt.org> References: <1337520014-28787-1-git-send-email-blogic@openwrt.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: linux-mips-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org, spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, Ralf Baechle , Thomas Langer To: John Crispin Return-path: In-Reply-To: <1337520014-28787-1-git-send-email-blogic-p3rKhJxN3npAfugRpC6u6w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org On 20/05/12 15:20, John Crispin wrote: > + master->mode_bits = SPI_MODE_3; > + master->num_chipselect = 1; > + master->bus_num = -1; once > + master->setup = falcon_sflash_setup; > + master->prepare_transfer_hardware = falcon_sflash_prepare_xfer; > + master->transfer_one_message = falcon_sflash_xfer_one; > + master->unprepare_transfer_hardware = falcon_sflash_unprepare_xfer; > + master->dev.of_node = pdev->dev.of_node; > + master->bus_num = -1; twice :-) sorry .... ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/