From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: Devin Heitmueller <dheitmueller@kernellabs.com>
Cc: Ismael Luceno <ismael.luceno@gmail.com>, linux-media@vger.kernel.org
Subject: Re: [PATCH 2/2] au0828: Move under dvb
Date: Sun, 20 May 2012 10:32:22 -0300 [thread overview]
Message-ID: <4FB8F266.7050308@redhat.com> (raw)
In-Reply-To: <CAGoCfizjD0wMpd+p4zxATfe+NKJqTqRTE4UEAZTTNdq9yCkxXg@mail.gmail.com>
Em 12-05-2012 07:21, Devin Heitmueller escreveu:
> On Fri, May 11, 2012 at 11:08 PM, Ismael Luceno <ismael.luceno@gmail.com> wrote:
>> On Fri, 11 May 2012 08:04:59 -0400
>> Devin Heitmueller <dheitmueller@kernellabs.com> wrote:
>> ...
>>> What is the motivation for moving these files?
>>
>> Well, the device was on the wrong Kconfig section, and while thinking
>> about changing that, I just thought to move it under DVB.
>>
>>> The au0828 is a hybrid bridge, and every other hybrid bridge is
>>> under video?
>>
>> Sorry, the devices I got don't support analog, so I didn't thought
>> about it that much...
>>
>> I guess it's arbitrary... isn't it? wouldn't it be better to have an
>> hybrid section? (just thinking out loud)
>
> Yeah, in this case it's largely historical (a product from before the
> V4L and DVB subsystems were merged). At this point I don't see any
> real advantage to arbitrarily moving the stuff around. And in fact in
> some areas it's even more ambiguous because some drivers are hybrid
> drivers but support both hybrid chips as well as analog-only (the
> em28xx driver is one such example).
>
> Anyway, Mauro is welcome to offer his opinion if it differs, but as
> far as I'm concerned this patch shouldn't get applied.
I won't apply this patch.
If the Kconfig menus are confusing, then we should fix it, instead of moving
things from one place to another ;)
>
> Cheers,
>
> Devin
>
next prev parent reply other threads:[~2012-05-20 13:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-11 6:14 [PATCH 1/2] au0828: Add USB ID used by many dongles Ismael Luceno
2012-05-11 6:14 ` [PATCH 2/2] au0828: Move under dvb Ismael Luceno
2012-05-11 12:04 ` Devin Heitmueller
2012-05-12 3:08 ` Ismael Luceno
2012-05-12 10:21 ` Devin Heitmueller
2012-05-20 13:32 ` Mauro Carvalho Chehab [this message]
2012-05-20 13:40 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FB8F266.7050308@redhat.com \
--to=mchehab@redhat.com \
--cc=dheitmueller@kernellabs.com \
--cc=ismael.luceno@gmail.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.