All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sakari Ailus <sakari.ailus@iki.fi>
To: Sylwester Nawrocki <sylvester.nawrocki@gmail.com>
Cc: linux-media@vger.kernel.org, mchehab@redhat.com,
	laurent.pinchart@ideasonboard.com,
	Sylwester Nawrocki <s.nawrocki@samsung.com>,
	Kyungmin Park <kyungmin.park@samsung.com>
Subject: Re: [PATCH] V4L: Remove "_ACTIVE" from the selection target name definitions
Date: Sun, 20 May 2012 23:00:43 +0300	[thread overview]
Message-ID: <4FB94D6B.2060104@iki.fi> (raw)
In-Reply-To: <1337523432-25148-1-git-send-email-sylvester.nawrocki@gmail.com>

Hi Sylwester,

Sylwester Nawrocki wrote:
> This patch drops the _ACTIVE part from the selection target names
> as a prerequisite to unify the selection target names across the subdev
> and regular video node API.
>
> The meaning of V4L2_SEL_TGT_*_ACTIVE and V4L2_SUBDEV_SEL_TGT_*_ACTUAL
> selection targets is logically the same. Different names add to confusion
> where both APIs are used in a single driver or an application. For some
> system configurations different names may lead to interoperability issues.
>
> For backwards compatibility V4L2_SEL_TGT_CROP_ACTIVE and
> V4L2_SEL_TGT_COMPOSE_ACTIVE are defined as aliases to V4L2_SEL_TGT_CROP
> and V4L2_SEL_TGT_COMPOSE. These aliases will be removed after deprecation
> period, according to Documentation/feature-removal-schedule.txt.
>
> Signed-off-by: Sylwester Nawrocki<s.nawrocki@samsung.com>
> Signed-off-by: Kyungmin Park<kyungmin.park@samsung.com>
> Acked-by: Laurent Pinchart<laurent.pinchart@ideasonboard.com>
> Signed-off-by: Sakari Ailus<sakari.ailus@iki.fi>
> ---
> This a replacement for this patch:  http://patchwork.linuxtv.org/patch/11226
> Changes include an adition of backward compatibility alias definitions and
> the required bits for FIMC-LITE driver.
>
> Sakari, do you think you could update you pull request with this patch ?
>
> I assumed the Acks still apply, if not, please let me know.

I'll send a new pull req with the new patch tomorrow, during early 
morning unless something unexpected happens.

Cheers,

-- 
Sakari Ailus
sakari.ailus@iki.fi

      reply	other threads:[~2012-05-20 20:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-19 18:10 [GIT PULL FOR 3.5] V4L2 and V4L2 subdev selection target rename Sakari Ailus
2012-05-20 14:17 ` [PATCH] V4L: Remove "_ACTIVE" from the selection target name definitions Sylwester Nawrocki
2012-05-20 20:00   ` Sakari Ailus [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FB94D6B.2060104@iki.fi \
    --to=sakari.ailus@iki.fi \
    --cc=kyungmin.park@samsung.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@redhat.com \
    --cc=s.nawrocki@samsung.com \
    --cc=sylvester.nawrocki@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.