From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 06/18] mfd: ab8500: Remove confusing ab8500-i2c file and merge into ab8500-core
Date: Mon, 21 May 2012 08:52:26 +0100 [thread overview]
Message-ID: <4FB9F43A.1040300@linaro.org> (raw)
In-Reply-To: <CACRpkdZWVpuZAmXV4fKTEvV7ke=NDGsej2iTSKdVy_e7gC9QQA@mail.gmail.com>
On 20/05/12 21:58, Linus Walleij wrote:
> On Thu, May 17, 2012 at 3:45 PM, Lee Jones<lee.jones@linaro.org> wrote:
>
>> ab8500-i2c is used as core code to register the ab8500 device.
>> After allocating ab8500 memory, it immediately calls into
>> ab8500-core where the real initialisation takes place. This
>> patch moves all core registration and memory allocation into
>> the true ab8500-core file and removes ab8500-i2c completely.
>>
>> Signed-off-by: Lee Jones<lee.jones@linaro.org>
>> ---
> (...)
>> +static int ab8500_i2c_write(struct ab8500 *ab8500, u16 addr, u8 data)
>
> So what happened to the promised (optional as add-on) patch also
> renaming these functions to ab8500_prcmu_write() etc?
>
> The reason I insist on not ACK:in on a "promise to fix later, really
> sure"-basis is exactly that these things tends to be forgotten ;-)
I have not forgotten. It's the 2nd and 3rd entry on my TODO list:
- TODO
<snip>
- Clean-up (simplify) ab8500-core
- Change i2c_[read|write] to prcmu_[read|write] - COMMENTS in [PATCH 06/15]
</snip>
Everything on my TODO gets done. :)
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
M: +44 77 88 633 515
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2012-05-21 7:52 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-17 13:45 [PATCH 00/18] DT enablement for Snowball Lee Jones
[not found] ` <1337262323-27692-1-git-send-email-lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2012-05-17 13:45 ` [PATCH 01/18] i2c: Add Device Tree support to the Nomadik I2C driver Lee Jones
2012-05-17 13:45 ` Lee Jones
2012-05-17 13:45 ` Lee Jones
[not found] ` <1337262323-27692-2-git-send-email-lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2012-05-20 20:53 ` Linus Walleij
2012-05-20 20:53 ` Linus Walleij
2012-05-20 20:53 ` Linus Walleij
2012-05-17 13:45 ` [PATCH 02/18] ARM: ux500: Remove unused i2c platform_data initialisation code Lee Jones
2012-05-17 13:45 ` [PATCH 03/18] ARM: ux500: Provide auxdata to be used as name base clock search for nmk-i2c Lee Jones
2012-05-17 13:45 ` [PATCH 04/18] ARM: ux500: CONFIG: Compile in support for leds-gpio Lee Jones
2012-05-17 13:45 ` [PATCH 05/18] ARM: ux500: Enable the user LED on Snowball via Device Tree Lee Jones
2012-05-17 13:45 ` [PATCH 06/18] mfd: ab8500: Remove confusing ab8500-i2c file and merge into ab8500-core Lee Jones
2012-05-20 20:58 ` Linus Walleij
2012-05-21 7:52 ` Lee Jones [this message]
2012-05-17 13:45 ` [PATCH 07/18] ARM: ux500: PRCMU related configuration and layout corrections for Device Tree Lee Jones
2012-05-17 13:45 ` [PATCH 08/18] mfd: Enable Device Tree for ab8500-core driver Lee Jones
2012-05-17 13:45 ` [PATCH 09/18] regulator: ab8500: Split up probe() into manageable pieces Lee Jones
2012-05-17 13:45 ` Lee Jones
2012-05-18 7:36 ` Mark Brown
2012-05-18 7:36 ` Mark Brown
2012-05-18 7:53 ` Lee Jones
2012-05-18 7:53 ` Lee Jones
2012-05-20 21:15 ` Linus Walleij
2012-05-20 21:15 ` Linus Walleij
2012-05-17 13:45 ` [PATCH 10/18] ARM: ux500: Add support for ab8500 regulators into the Device Tree Lee Jones
2012-05-17 13:45 ` [PATCH 11/18] regulator: Enable the ab8500 for " Lee Jones
2012-05-17 13:45 ` Lee Jones
2012-05-18 7:36 ` Mark Brown
2012-05-18 7:36 ` Mark Brown
2012-05-18 7:52 ` Lee Jones
2012-05-18 7:52 ` Lee Jones
2012-05-20 21:14 ` Linus Walleij
2012-05-20 21:14 ` Linus Walleij
2012-05-17 13:45 ` [PATCH 12/18] ARM: ux500: Disable platform setup of the ab8500 when DT is enabled Lee Jones
2012-05-17 21:22 ` Arnd Bergmann
2012-05-17 21:58 ` Lee Jones
2012-05-18 10:38 ` Arnd Bergmann
2012-05-18 11:00 ` Lee Jones
2012-05-18 11:12 ` Arnd Bergmann
2012-05-18 12:36 ` Lee Jones
2012-05-18 20:38 ` Arnd Bergmann
2012-05-17 13:45 ` [PATCH 13/18] ARM: ux500: Apply ab8500-debug node do the db8500 DT structure Lee Jones
2012-05-20 21:00 ` Linus Walleij
2012-05-17 13:45 ` [PATCH 14/18] mfd: Enable ab8500-debug when Device Tree is enabled Lee Jones
2012-05-20 21:00 ` Linus Walleij
2012-05-17 13:45 ` [PATCH 15/18] mfd: Prevent unassigned pointer from being used in ab8500-gpadc driver Lee Jones
2012-05-20 21:02 ` Linus Walleij
2012-05-17 13:45 ` [PATCH 16/18] ARM: ux500: Add a ab8500-gpadc node to the db8500 Device Tree Lee Jones
2012-05-20 21:01 ` Linus Walleij
2012-05-17 13:45 ` [PATCH 17/18] mfd: Enable ab8500-gpadc driver for " Lee Jones
2012-05-20 21:02 ` Linus Walleij
2012-05-17 13:45 ` [PATCH 18/18] ARM: ux500: Add support for input/ponkey into the db8500's " Lee Jones
2012-05-20 21:03 ` Linus Walleij
2012-05-17 21:25 ` [PATCH 00/18] DT enablement for Snowball Arnd Bergmann
2012-05-17 21:41 ` Mark Brown
2012-05-17 21:49 ` Lee Jones
2012-05-19 15:25 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FB9F43A.1040300@linaro.org \
--to=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.