From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:59703) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SWNlV-0000UV-PB for qemu-devel@nongnu.org; Mon, 21 May 2012 04:14:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SWNlR-00041O-2t for qemu-devel@nongnu.org; Mon, 21 May 2012 04:14:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:14787) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SWNlQ-00041I-Qz for qemu-devel@nongnu.org; Mon, 21 May 2012 04:14:49 -0400 Message-ID: <4FB9F973.7030800@redhat.com> Date: Mon, 21 May 2012 10:14:43 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <4FB9F402.9040600@redhat.com> <4FB9F8C0.3040801@redhat.com> In-Reply-To: <4FB9F8C0.3040801@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] qtest: add a fuzz test to fdc-test List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Blue Swirl , qemu-devel Am 21.05.2012 10:11, schrieb Paolo Bonzini: > Il 21/05/2012 09:51, Kevin Wolf ha scritto: >>>> GTESTER check-qtest-i386 >>>> FLOPPY ERROR: fdctrl_read_data: controller not ready for reading >>>> FLOPPY ERROR: fdctrl_read_data: controller not ready for reading >>>> FLOPPY ERROR: fdctrl_unimplemented: unimplemented command 0x1f >>>> FLOPPY ERROR: fdctrl_unimplemented: unimplemented command 0xa8 >>>> FLOPPY ERROR: fdctrl_read_data: controller not ready for reading >>>> FLOPPY ERROR: fdctrl_read_data: controller not ready for reading >>>> FLOPPY ERROR: fdctrl_read_data: controller not ready for reading >>>> FLOPPY ERROR: fdctrl_unimplemented: unimplemented command 0x37 >>>> FLOPPY ERROR: fdctrl_read_data: controller not ready for reading >>>> FLOPPY ERROR: fdctrl_read_data: controller not ready for reading >>>> FLOPPY ERROR: fdctrl_read_data: controller not ready for reading >>>> FLOPPY ERROR: fdctrl_read_data: controller not ready for reading >>>> FLOPPY ERROR: fdctrl_read_data: controller not ready for reading >>>> FLOPPY ERROR: fdctrl_read_data: controller not ready for reading >>>> FLOPPY ERROR: fdctrl_unimplemented: unimplemented command 0x93 >>>> FLOPPY ERROR: fdctrl_unimplemented: unimplemented command 0xe4 >>>> FLOPPY ERROR: fdctrl_unimplemented: unimplemented command 0xc1 >>>> FLOPPY ERROR: fdctrl_unimplemented: unimplemented command 0x92 >>>> >>>> Maybe they should be fixed first. >> What do you mean by fixing? Turning them into DPRINTFs? > > Or trace events? Yeah, you could turn all FLOPPY_DPRINTFs into trace events. But the point here is that today it's a FLOPPY_ERROR, and except for register fuzzing they report real problems with the emulation and not just some debugging information. So I'm not sure if hiding them is really a fix. Kevin