From: Kevin Wolf <kwolf@redhat.com>
To: Jim Meyering <jim@meyering.net>
Cc: qemu list <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCHv2 1/6] qcow2: don't leak buffer for unexpected qcow_version in header
Date: Mon, 21 May 2012 13:24:13 +0200 [thread overview]
Message-ID: <4FBA25DD.1080701@redhat.com> (raw)
In-Reply-To: <87bolhn67l.fsf@rho.meyering.net>
Am 21.05.2012 13:06, schrieb Jim Meyering:
>
> Signed-off-by: Jim Meyering <meyering@redhat.com>
> ---
> Thanks to Kevin Wolf for the improvement.
>
> block/qcow2.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/block/qcow2.c b/block/qcow2.c
> index 655799c..c2e49cd 100644
> --- a/block/qcow2.c
> +++ b/block/qcow2.c
> @@ -919,7 +919,8 @@ int qcow2_update_header(BlockDriverState *bs)
> ret = sizeof(*header);
> break;
> default:
> - return -EINVAL;
> + ret = -EINVAL;
> + goto fail;
> }
>
> buf += ret;
> --
> 1.7.10.2.552.gaa3bb87
Acked-by: Kevin Wolf <kwolf@redhat.com>
next prev parent reply other threads:[~2012-05-21 11:24 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-16 13:07 [Qemu-devel] [PATCH 0/6] plug memory and file-descriptor leaks Jim Meyering
2012-05-16 13:07 ` [Qemu-devel] [PATCH 1/6] qcow2: don't leak buffer for unexpected qcow_version in header Jim Meyering
2012-05-21 10:57 ` Kevin Wolf
2012-05-21 11:06 ` [Qemu-devel] [PATCHv2 " Jim Meyering
2012-05-21 11:24 ` Kevin Wolf [this message]
2012-05-21 11:07 ` [Qemu-devel] [PATCH " Jim Meyering
2012-05-16 13:07 ` [Qemu-devel] [PATCH 2/6] qemu-ga: avoid unconditional lockfile file descriptor leak Jim Meyering
2012-05-16 18:15 ` Michael Roth
2012-05-16 20:17 ` Jim Meyering
2012-05-16 20:19 ` [Qemu-devel] [PATCHv2 2/6] qemu-ga: don't leak a file descriptor upon failed lockf Jim Meyering
2012-05-16 20:58 ` Michael Roth
2012-05-16 13:07 ` [Qemu-devel] [PATCH 3/6] linux-user: do_msgrcv: don't leak host_mb upon TARGET_EFAULT failure Jim Meyering
2012-05-16 13:21 ` Peter Maydell
2012-05-16 13:50 ` Jim Meyering
2012-05-16 13:52 ` [Qemu-devel] [PATCHv2 " Jim Meyering
2012-05-16 13:07 ` [Qemu-devel] [PATCH 4/6] sheepdog: don't leak socket file descriptor upon connection failure Jim Meyering
2012-05-21 11:00 ` Kevin Wolf
2012-08-17 13:30 ` Jim Meyering
2012-08-17 13:40 ` Kevin Wolf
2012-08-17 13:42 ` Jim Meyering
2012-05-16 13:08 ` [Qemu-devel] [PATCH 5/6] arm-semi: don't leak 1kb user string lock buffer upon TARGET_SYS_OPEN Jim Meyering
2012-05-16 13:15 ` Peter Maydell
2012-05-16 13:08 ` [Qemu-devel] [PATCH 6/6] softmmu-semi: fix lock_user* functions not to deref NULL upon OOM Jim Meyering
2012-05-19 7:13 ` Matthew Fernandez
2012-05-19 15:46 ` Peter Maydell
2012-05-24 14:46 ` Jim Meyering
2012-05-24 14:46 ` [Qemu-devel] [PATCH v2 " Jim Meyering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FBA25DD.1080701@redhat.com \
--to=kwolf@redhat.com \
--cc=jim@meyering.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.