From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60335) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SWU7O-0008JB-Hv for qemu-devel@nongnu.org; Mon, 21 May 2012 11:01:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SWU7I-0005J1-BL for qemu-devel@nongnu.org; Mon, 21 May 2012 11:01:54 -0400 Received: from david.siemens.de ([192.35.17.14]:29682) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SWU7I-0005Iu-1R for qemu-devel@nongnu.org; Mon, 21 May 2012 11:01:48 -0400 Message-ID: <4FBA58D3.30508@siemens.com> Date: Mon, 21 May 2012 12:01:39 -0300 From: Jan Kiszka MIME-Version: 1.0 References: <72a3d008-2d67-47e8-b5f2-927ff5cf2166@zmail16.collab.prod.int.phx2.redhat.com> <4FAAFA99.7000902@suse.de> <4FBA562E.2020407@redhat.com> In-Reply-To: <4FBA562E.2020407@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH RFC 6/6] target-i386: make cpus childs of /machine List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: Paolo Bonzini , "aliguori@us.ibm.com" , =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , "qemu-devel@nongnu.org" On 2012-05-21 11:50, Igor Mammedov wrote: >> I've used cpu_index, but it seems cpuid_apic_id is assigned only once, >> from cpu_index, so it should be identical. What's the difference? > Once Jan voiced that user visible cpu id, should be apic_id in context of cpu hotplug > (i.e. when doing: device_add xxx_cpu,id=12345,...) > "Jan, please correct me if I've got you wrong." > So QOM tree probably should reflect this id and not cpu_index. > > However cpu_index and apic_id are the same now and bios assumes it as well. > What are possible benefits of using cpuid_apic_id != cpu_index for qemu? >>From my POV, cpu_index could become equal to the physical APIC ID. As long as we can set it freely (provided it remains unique) and non-continuously, we don't need separate indexes. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux