From: David Daney <david.daney@cavium.com>
To: "Steven J. Hill" <sjhill@mips.com>
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org
Subject: Re: [PATCH v3,2/9] MIPS: Optimise core library functions for microMIPS.
Date: Mon, 21 May 2012 10:55:54 -0700 [thread overview]
Message-ID: <4FBA81AA.9090801@cavium.com> (raw)
In-Reply-To: <1337615935-30482-1-git-send-email-sjhill@mips.com>
[...]
> --- a/arch/mips/include/asm/page.h
> +++ b/arch/mips/include/asm/page.h
> @@ -45,6 +45,12 @@
> #define HUGETLB_PAGE_ORDER ({BUILD_BUG(); 0; })
> #endif /* CONFIG_HUGETLB_PAGE */
>
> +/*
> + * Clear and copy array sizes for micro-assembly of clear_page/copy_page.
> + */
> +#define CLEAR_PAGE_ARRAY_SIZE 288
> +#define COPY_PAGE_ARRAY_SIZE 1344
> +
This is not so clean. page.h really shouldn't have things like this.
Just put a label at the beginning and end of the code and have the
compiler calculate the size from the difference.
David Daney
prev parent reply other threads:[~2012-05-21 17:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-21 15:58 [PATCH v3,2/9] MIPS: Optimise core library functions for microMIPS Steven J. Hill
2012-05-21 17:55 ` David Daney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FBA81AA.9090801@cavium.com \
--to=david.daney@cavium.com \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=sjhill@mips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.