From: Chris Ferron <chris.e.ferron at linux.intel.com>
To: powertop@lists.01.org
Subject: Re: [Powertop] [PATCH 2/3] Remove redundant inclusion of -O2 -g in powertop_CXXFLAGS
Date: Mon, 21 May 2012 15:16:21 -0700 [thread overview]
Message-ID: <4FBABEB5.9090502@linux.intel.com> (raw)
In-Reply-To: 1337631481.2616.1.camel@sara
[-- Attachment #1: Type: text/plain, Size: 1430 bytes --]
On 05/21/2012 12:46 PM, Magnus Fromreide wrote:
> When building a program then program_CXXFLAGS replaces AM_CXXFLAGS and
> CXXFLAGS is appended to it, this is the reason for the double -O2 -g options
> when building the powertop binary.
>
> This patch removes the extra -O2 -g and returns the control of the optimization
> and debug flags to CXXFLAGS as one would expect.
>
> Please note that the default value of CXXFLAGS is -O2 -g if the compiler
> supports it.
>
> Signed-off-by: Magnus Fromreide<magfr(a)lysator.liu.se>
> ---
> src/Makefile.am | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/Makefile.am b/src/Makefile.am
> index e26c8bc..3e8294a 100644
> --- a/src/Makefile.am
> +++ b/src/Makefile.am
> @@ -33,7 +33,7 @@ powertop_SOURCES = parameters/persistent.cpp parameters/learn.cpp parameters/par
> main.cpp css.h powertop.css
>
>
> -powertop_CXXFLAGS = -O2 -g -fno-omit-frame-pointer -fstack-protector -Wall -Wshadow -Wformat -I/usr/include/ $(NCURSES_CFLAGS) $(PCIUTILS_CFLAGS) $(LIBNL_CFLAGS) $(GLIB2_CFLAGS)
> +powertop_CXXFLAGS = -fno-omit-frame-pointer -fstack-protector -Wall -Wshadow -Wformat -I/usr/include/ $(NCURSES_CFLAGS) $(PCIUTILS_CFLAGS) $(LIBNL_CFLAGS) $(GLIB2_CFLAGS)
>
>
> powertop_CPPFLAGS = -D_FORTIFY_SOURCE=2 $(NCURSES_CFLAGS) $(PCIUTILS_CFLAGS) $(LIBNL_CFLAGS) $(GLIB2_CFLAGS) $(LIBZ_CFLAGS)
patch applied
Thank You
-Chris
next reply other threads:[~2012-05-21 22:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-21 22:16 Chris Ferron [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-05-21 19:46 [Powertop] [PATCH 2/3] Remove redundant inclusion of -O2 -g in powertop_CXXFLAGS Magnus Fromreide
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FBABEB5.9090502@linux.intel.com \
--to=powertop@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.