Re: [Powertop] [PATCH 2/3] Remove redundant inclusion of -O2 -g in powertop_CXXFLAGS

Re: [Powertop] [PATCH 2/3] Remove redundant inclusion of -O2 -g in powertop_CXXFLAGS

[Chris Ferron]

[-- Attachment #1: Type: text/plain, Size: 1430 bytes --]

On 05/21/2012 12:46 PM, Magnus Fromreide wrote:
> When building a program then program_CXXFLAGS replaces AM_CXXFLAGS and
> CXXFLAGS is appended to it, this is the reason for the double -O2 -g options
> when building the powertop binary.
>
> This patch removes the extra -O2 -g and returns the control of the optimization
> and debug flags to CXXFLAGS as one would expect.
>
> Please note that the default value of CXXFLAGS is -O2 -g if the compiler
> supports it.
>
> Signed-off-by: Magnus Fromreide<magfr(a)lysator.liu.se>
> ---
>   src/Makefile.am |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/Makefile.am b/src/Makefile.am
> index e26c8bc..3e8294a 100644
> --- a/src/Makefile.am
> +++ b/src/Makefile.am
> @@ -33,7 +33,7 @@ powertop_SOURCES = parameters/persistent.cpp parameters/learn.cpp parameters/par
>   		main.cpp css.h powertop.css
>
>
> -powertop_CXXFLAGS = -O2 -g -fno-omit-frame-pointer -fstack-protector -Wall -Wshadow -Wformat -I/usr/include/ $(NCURSES_CFLAGS) $(PCIUTILS_CFLAGS) $(LIBNL_CFLAGS) $(GLIB2_CFLAGS)
> +powertop_CXXFLAGS = -fno-omit-frame-pointer -fstack-protector -Wall -Wshadow -Wformat -I/usr/include/ $(NCURSES_CFLAGS) $(PCIUTILS_CFLAGS) $(LIBNL_CFLAGS) $(GLIB2_CFLAGS)
>
>
>   powertop_CPPFLAGS = -D_FORTIFY_SOURCE=2 $(NCURSES_CFLAGS) $(PCIUTILS_CFLAGS) $(LIBNL_CFLAGS) $(GLIB2_CFLAGS) $(LIBZ_CFLAGS)
patch applied
Thank You
-Chris

[Powertop] [PATCH 2/3] Remove redundant inclusion of -O2 -g in powertop_CXXFLAGS

[Magnus Fromreide]

[-- Attachment #1: Type: text/plain, Size: 1315 bytes --]

When building a program then program_CXXFLAGS replaces AM_CXXFLAGS and
CXXFLAGS is appended to it, this is the reason for the double -O2 -g options
when building the powertop binary.

This patch removes the extra -O2 -g and returns the control of the optimization
and debug flags to CXXFLAGS as one would expect.

Please note that the default value of CXXFLAGS is -O2 -g if the compiler
supports it.

Signed-off-by: Magnus Fromreide <magfr(a)lysator.liu.se>
---
 src/Makefile.am |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/Makefile.am b/src/Makefile.am
index e26c8bc..3e8294a 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -33,7 +33,7 @@ powertop_SOURCES = parameters/persistent.cpp parameters/learn.cpp parameters/par
 		main.cpp css.h powertop.css
 
 
-powertop_CXXFLAGS = -O2 -g -fno-omit-frame-pointer -fstack-protector -Wall -Wshadow -Wformat -I/usr/include/ $(NCURSES_CFLAGS) $(PCIUTILS_CFLAGS) $(LIBNL_CFLAGS) $(GLIB2_CFLAGS)
+powertop_CXXFLAGS = -fno-omit-frame-pointer -fstack-protector -Wall -Wshadow -Wformat -I/usr/include/ $(NCURSES_CFLAGS) $(PCIUTILS_CFLAGS) $(LIBNL_CFLAGS) $(GLIB2_CFLAGS)
 
 
 powertop_CPPFLAGS = -D_FORTIFY_SOURCE=2 $(NCURSES_CFLAGS) $(PCIUTILS_CFLAGS) $(LIBNL_CFLAGS) $(GLIB2_CFLAGS) $(LIBZ_CFLAGS)
-- 
1.7.10