Re: [Qemu-devel] [PATCH v11 2/9] Add migration capabilites

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1236 bytes --]

On 05/22/2012 06:56 AM, Orit Wasserman wrote:
> Add migration capabiltes that can be queried by the management.
> The managment can query the source QEMU and the destination QEMU in order to
> verify both support some  migration capability (currently only XBZRLE).
> The managment can enable a capabilty for the next migration by using
> migrate_set_parameter command.
> 

>  ##
> +# @MigrationCapability
> +#
> +# Migration capabilities enumaration
> +#
> +# @xbzrle: current migration supports xbzrle
> +#
> +# Since: 1.1

1.2

> +##
> +{ 'enum': 'MigrationCapability',
> +  'data': ['xbzrle'] }
> +

> +
> +##
> +# @migrate_set_parameter
> +#
> +# Set the following migration parameters (like xbzrle )
> +##
> +# Since: 1.2
> +##
> +{ 'command': 'migrate-set-parameter', 'data': { 'parameter': 'str' } }

This requires libvirt to issue multiple monitor commands in a row.
Also, it's pretty poorly typed.  It might be nicer to provide:

{ 'command': 'migrate-set-parameters',
  'data': { 'parameters': ['MigrationCapability'] } }

so that I can set multiple parameters in one call.

-- 
Eric Blake   eblake@redhat.com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 620 bytes --]