From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2 1/2] Add env vars describing U-Boot target board
Date: Tue, 22 May 2012 10:16:12 -0600 [thread overview]
Message-ID: <4FBBBBCC.5020309@wwwdotorg.org> (raw)
In-Reply-To: <20120522082356.5C78C200239@gemini.denx.de>
On 05/22/2012 02:23 AM, Wolfgang Denk wrote:
> Dear Stephen Warren,
>
> In message <1337643054-17290-1-git-send-email-swarren@wwwdotorg.org> you wrote:
>> From: Stephen Warren <swarren@nvidia.com>
>>
>> This can be useful for generic scripts. For example, rather than hard-
>> coding a script to ext2load tegra-harmony.dtb, it could load
>> ${soc}-${board}.dtb and hence not need adjustments to run on multiple
>> boards.
> ...
>
>> +echo "#define ARCH \"${arch}\"" >> config.h
>> +echo "#define CPU \"${cpu}\"" >> config.h
>> +echo "#define BOARD \"${board}\"" >> config.h
>
> Sorry, but names like ARCH and CPU are _way_ too intrusive and likely
> to clash. Please use something like CONFIG_SYS_ARCH_NAME etc.
> instead.
OK. Are you OK with the environment variable names? They're also common
names like arch, cpu, board, vendor, soc.
next prev parent reply other threads:[~2012-05-22 16:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-21 23:30 [U-Boot] [PATCH V2 1/2] Add env vars describing U-Boot target board Stephen Warren
2012-05-21 23:30 ` [U-Boot] [PATCH V2 2/2] tegra: enable CONFIG_ENV_VARS_UBOOT_CONFIG Stephen Warren
2012-05-22 8:23 ` [U-Boot] [PATCH V2 1/2] Add env vars describing U-Boot target board Wolfgang Denk
2012-05-22 16:16 ` Stephen Warren [this message]
2012-05-22 18:03 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FBBBBCC.5020309@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.